Skip to content

Commit 47cc1fc

Browse files
authored
Set default Gradle Version to 8 (#891)
Set default Gradle version to 8 Address review comments
1 parent cf03b7a commit 47cc1fc

23 files changed

Lines changed: 94 additions & 401 deletions

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414

1515
- Add Google Truth for easier to debug assertions in tests ([#920](https://github.com/getsentry/sentry-android-gradle-plugin/pull/920))
1616

17+
### Dependencies
18+
19+
- Set build default Gradle Version to 8.14.2 ([#891](https://github.com/getsentry/sentry-android-gradle-plugin/pull/891))
20+
1721
## 5.8.0
1822

1923
### Dependencies

buildSrc/src/main/java/Dependencies.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import org.gradle.util.VersionNumber
1+
import org.gradle.util.internal.VersionNumber
22

33
object BuildPluginsVersion {
4-
val AGP = System.getenv("VERSION_AGP") ?: "7.4.0"
5-
val GROOVY_REDISTRIBUTED = System.getenv("VERSION_GROOVY") ?: "1.2"
4+
val AGP = System.getenv("VERSION_AGP") ?: "8.10.1"
5+
val GROOVY_REDISTRIBUTED = System.getenv("VERSION_GROOVY") ?: "1.7.1"
66

77
// proguard does not support AGP 8 yet
88
fun isProguardApplicable(): Boolean = VersionNumber.parse(AGP).major < 8

gradle/libs.versions.toml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[versions]
22
kotlin = "1.8.20"
3-
agp = "7.4.0"
3+
agp = "8.10.1"
44

55
asm = "9.4" # // compatibility matrix -> https://developer.android.com/reference/tools/gradle-api/7.1/com/android/build/api/instrumentation/InstrumentationContext#apiversion
66
ktfmt = "0.51"
@@ -19,7 +19,7 @@ kotlinSpring = { id = "org.jetbrains.kotlin.plugin.spring", version.ref = "kotli
1919
kapt = { id = "org.jetbrains.kotlin.kapt", version.ref = "kotlin" }
2020
dokka = { id = "org.jetbrains.dokka", version = "1.8.10" }
2121
spotless = { id = "com.diffplug.spotless", version = "7.0.4" }
22-
groovyGradlePlugin = { id = "dev.gradleplugins.groovy-gradle-plugin", version = "1.2" }
22+
groovyGradlePlugin = { id = "dev.gradleplugins.groovy-gradle-plugin", version = "1.7.1" }
2323
mavenPublish = { id = "com.vanniktech.maven.publish", version = "0.27.0" }
2424
androidApplication = { id = "com.android.application", version.ref = "agp" }
2525
androidLibrary = { id = "com.android.library", version.ref = "agp" }
@@ -33,7 +33,9 @@ proguard = { group = "com.guardsquare", name = "proguard-gradle", version = "7.5
3333
# this allows us to develop against a fixed version of Gradle, as opposed to depending on the
3434
# locally available version. kotlin-gradle-plugin follows the same approach.
3535
# More info: https://docs.nokee.dev/manual/gradle-plugin-development-plugin.html
36-
gradleApi = { group = "dev.gradleplugins", name = "gradle-api", version = "7.6.4" }
36+
# The latest version is 8.11.1 https://github.com/gradle-plugins/gradle-api/issues/6
37+
# 8.8 or higher fails groovy compilation
38+
gradleApi = { group = "dev.gradleplugins", name = "gradle-api", version = "8.7" }
3739
agp = { group = "com.android.tools.build", name = "gradle", version.ref = "agp" }
3840
kotlinCompilerEmbeddable = { group = "org.jetbrains.kotlin", name = "kotlin-compiler-embeddable" }
3941
autoService = { group = "com.google.auto.service", name = "auto-service", version = "1.0.1" }

gradle/wrapper/gradle-wrapper.jar

-17.4 KB
Binary file not shown.
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.4-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.2-bin.zip
44
networkTimeout=10000
5+
validateDistributionUrl=true
56
zipStoreBase=GRADLE_USER_HOME
67
zipStorePath=wrapper/dists

gradlew

Lines changed: 22 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gradlew.bat

Lines changed: 14 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugin-build/build.gradle.kts

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,45 @@ tasks.named("distZip") {
192192
onlyIf { inputs.sourceFiles.isEmpty.not().also { require(it) { "No distribution to zip." } } }
193193
}
194194

195+
tasks.named("distTar").configure {
196+
dependsOn(
197+
"dokkaJavadocJar",
198+
"jar",
199+
"sourcesJar",
200+
"generateMetadataFileForPluginMavenPublication",
201+
"generatePomFileForPluginMavenPublication",
202+
)
203+
}
204+
205+
tasks.named("sentryJvmPluginMarkerDistTar").configure {
206+
dependsOn(
207+
"generatePomFileForSentryJvmPluginPluginMarkerMavenPublication",
208+
"generatePomFileForKotlinCompilerPluginPluginMarkerMavenPublication",
209+
)
210+
}
211+
212+
tasks.named("sentryJvmPluginMarkerDistZip").configure {
213+
dependsOn("generatePomFileForSentryJvmPluginPluginMarkerMavenPublication")
214+
}
215+
216+
tasks.named("dokkaHtml").configure { dependsOn("compileGroovy") }
217+
218+
tasks.named("sentryKotlinCompilerPluginMarkerDistTar").configure {
219+
dependsOn("generatePomFileForKotlinCompilerPluginPluginMarkerMavenPublication")
220+
}
221+
222+
tasks.named("sentryKotlinCompilerPluginMarkerDistZip").configure {
223+
dependsOn("generatePomFileForKotlinCompilerPluginPluginMarkerMavenPublication")
224+
}
225+
226+
tasks.named("sentryPluginMarkerDistTar").configure {
227+
dependsOn("generatePomFileForSentryPluginPluginMarkerMavenPublication")
228+
}
229+
230+
tasks.named("sentryPluginMarkerDistZip").configure {
231+
dependsOn("generatePomFileForSentryPluginPluginMarkerMavenPublication")
232+
}
233+
195234
tasks.withType<Test>().configureEach {
196235
testLogging {
197236
events = setOf(TestLogEvent.SKIPPED, TestLogEvent.PASSED, TestLogEvent.FAILED)

plugin-build/buildSrc/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
plugins {
22
`kotlin-dsl`
33
id("java-gradle-plugin")
4-
kotlin("jvm") version "1.8.20"
54
}
65

76
repositories { mavenCentral() }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
dependencyResolutionManagement {
2-
versionCatalogs { create("libs") { from(files("../gradle/libs.versions.toml")) } }
2+
versionCatalogs { create("libs") { from(files("../../gradle/libs.versions.toml")) } }
33
}

0 commit comments

Comments
 (0)