Skip to content

Commit 540e5d7

Browse files
runningcodeclaude
andauthored
refactor: Inject ObjectFactory instead of Project in SentryPluginExtension (#1181)
SentryPluginExtension only used Project to get ObjectFactory. Injecting ObjectFactory directly removes the unnecessary Project dependency. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent bc903d2 commit 540e5d7

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ constructor(private val buildEvents: BuildEventListenerRegistryInternal) : Plugi
4141
)
4242
}
4343

44-
val extension = project.extensions.create("sentry", SentryPluginExtension::class.java, project)
44+
val extension = project.extensions.create("sentry", SentryPluginExtension::class.java)
4545

4646
project.pluginManager.withPlugin("com.android.application") {
4747
val androidComponentsExt =

plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SentryPluginExtension.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@ package io.sentry.android.gradle.extensions
33
import io.sentry.android.gradle.telemetry.SentryTelemetryService.Companion.SENTRY_SAAS_DSN
44
import javax.inject.Inject
55
import org.gradle.api.Action
6-
import org.gradle.api.Project
6+
import org.gradle.api.model.ObjectFactory
77
import org.gradle.api.provider.Property
88
import org.gradle.api.provider.SetProperty
99
import org.jetbrains.annotations.ApiStatus.Experimental
1010

11-
abstract class SentryPluginExtension @Inject constructor(project: Project) {
12-
13-
private val objects = project.objects
11+
abstract class SentryPluginExtension @Inject constructor(objects: ObjectFactory) {
1412

1513
/**
1614
* Disables or enables the handling of Proguard mapping for Sentry. If enabled the plugin will

plugin-build/src/main/kotlin/io/sentry/jvm/gradle/SentryJvmPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ constructor(private val buildEvents: BuildEventListenerRegistryInternal) : Plugi
3535
private val configuredForJavaProject = AtomicBoolean(false)
3636

3737
override fun apply(project: Project) {
38-
val extension = project.extensions.create("sentry", SentryPluginExtension::class.java, project)
38+
val extension = project.extensions.create("sentry", SentryPluginExtension::class.java)
3939

4040
project.pluginManager.withPlugin("org.gradle.java") {
4141
if (configuredForJavaProject.getAndSet(true)) {

0 commit comments

Comments
 (0)