Skip to content

Commit 91a36c2

Browse files
runningcodeclaude
andcommitted
ref(build): Consolidate sentry-java version into version catalog
The sentry SDK version was declared twice: once in libs.versions.toml (7.0.0, used for the plugin's own compile dependency) and once in gradle.properties as sdk_version (8.43.0, used as BuildConfig.SdkVersion for auto-installation defaults and telemetry). Consolidate into a single source of truth in libs.versions.toml and read it via libs.versions.sentry in build.gradle.kts. Dependabot (gradle package ecosystem, directory "/") now handles updates to the sentry version via libs.versions.toml, making the custom getsentry/github-workflows/updater job and scripts/update-android.sh redundant. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 8bc4f08 commit 91a36c2

5 files changed

Lines changed: 2 additions & 41 deletions

File tree

.github/workflows/update-deps.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,6 @@ jobs:
2525
name: CLI
2626
ssh-key: ${{ secrets.CI_DEPLOY_KEY }}
2727

28-
android:
29-
runs-on: ubuntu-latest
30-
steps:
31-
- uses: getsentry/github-workflows/updater@607fed74f812e69201531a5185b6c3c57caa4e89 # v3
32-
with:
33-
path: scripts/update-android.sh
34-
name: Android SDK
35-
ssh-key: ${{ secrets.CI_DEPLOY_KEY }}
36-
3728
composable-preview-scanner:
3829
runs-on: ubuntu-latest
3930
steps:

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ agp = "8.10.1"
55
asm = "9.4" # // compatibility matrix -> https://developer.android.com/reference/tools/gradle-api/7.1/com/android/build/api/instrumentation/InstrumentationContext#apiversion
66
ktfmt = "0.51"
77
sqlite = "2.1.0"
8-
sentry = "7.0.0"
8+
sentry = "8.43.0"
99

1010
sampleCoroutines = "1.5.2"
1111
sampleRoom = "2.7.2"

plugin-build/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ buildConfig {
322322
className("BuildConfig")
323323

324324
buildConfigField("String", "Version", provider { "\"${project.version}\"" })
325-
buildConfigField("String", "SdkVersion", provider { "\"${project.property("sdk_version")}\"" })
325+
buildConfigField("String", "SdkVersion", libs.versions.sentry.map { "\"$it\"" })
326326
buildConfigField("String", "AgpVersion", provider { "\"${BuildPluginsVersion.AGP}\"" })
327327
buildConfigField("String", "CliVersion", propertyVersionProvider("sentry-cli.properties"))
328328
buildConfigField(

plugin-build/gradle.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ org.gradle.parallel=true
88
name = sentry-android-gradle-plugin
99
group = io.sentry
1010
version = 6.9.0
11-
sdk_version = 8.43.0
1211

1312
# publication pom properties
1413
POM_NAME=Sentry Android Gradle Plugin

scripts/update-android.sh

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)