Skip to content

Commit df80572

Browse files
authored
fix(snapshots): Use snake_case for sidecar metadata JSON keys (#1157)
Normalize all keys in the per-snapshot sidecar metadata JSON to snake_case. Previously only `display_name` and `image_file_name` were snake_case while the remaining ten keys used camelCase, forcing downstream consumers to handle both conventions.
1 parent 49a3a29 commit df80572

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/GenerateSnapshotTestsTask.kt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -361,20 +361,20 @@ class $CLASS_NAME(
361361
val metadata = linkedMapOf<String, Any>(
362362
"display_name" to screenshotId.removePrefix(preview.declaringClass + "."),
363363
"image_file_name" to screenshotId,
364-
"className" to preview.declaringClass,
365-
"methodName" to preview.methodName,
364+
"class_name" to preview.declaringClass,
365+
"method_name" to preview.methodName,
366366
)
367367
if (info.group.isNotBlank()) metadata["group"] = info.group
368-
if (info.name.isNotBlank()) metadata["previewName"] = info.name
368+
if (info.name.isNotBlank()) metadata["preview_name"] = info.name
369369
if (info.locale.isNotBlank()) metadata["locale"] = info.locale
370370
if (info.device.isNotBlank()) metadata["device"] = info.device
371-
metadata["nightMode"] = (info.uiMode and UI_MODE_NIGHT_MASK == UI_MODE_NIGHT_YES)
372-
if (info.fontScale != 1f) metadata["fontScale"] = info.fontScale
373-
if (info.apiLevel != -1) metadata["apiLevel"] = info.apiLevel
374-
if (info.widthDp > 0) metadata["widthDp"] = info.widthDp
375-
if (info.heightDp > 0) metadata["heightDp"] = info.heightDp
376-
if (info.showSystemUi) metadata["showSystemUi"] = true
377-
if (info.showBackground) metadata["showBackground"] = true
371+
metadata["night_mode"] = (info.uiMode and UI_MODE_NIGHT_MASK == UI_MODE_NIGHT_YES)
372+
if (info.fontScale != 1f) metadata["font_scale"] = info.fontScale
373+
if (info.apiLevel != -1) metadata["api_level"] = info.apiLevel
374+
if (info.widthDp > 0) metadata["width_dp"] = info.widthDp
375+
if (info.heightDp > 0) metadata["height_dp"] = info.heightDp
376+
if (info.showSystemUi) metadata["show_system_ui"] = true
377+
if (info.showBackground) metadata["show_background"] = true
378378
379379
val json = metadata.entries.joinToString(",\n ", prefix = "{\n ", postfix = "\n}") { (k, v) ->
380380
if (v is String) "\"" + k + "\": \"" + escapeJson(v) + "\""

0 commit comments

Comments
 (0)