Skip to content

refactor(distribution): Remove validation requiring distribution.enabled for updateSdkVariants #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 1 commit into from
Oct 28, 2025
Merged

refactor(distribution): Remove validation requiring distribution.enabled for updateSdkVariants #1019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,6 @@ fun ApplicationAndroidComponentsExtension.configure(
"You cannot use the auto-update SDK in variants where the Sentry SDK is disabled."
)
}

// Check if updateSdkVariants is set but distribution uploads are disabled
val distributionEnabled = extension.distribution.enabled.get()
if (!distributionEnabled) {
throw IllegalArgumentException(
"Invalid configuration: updateSdkVariants contains variant '$variantName' but buildDistribution.enabled is false. " +
"It doesn't make sense to embed the auto-update SDK without uploading the build."
)
}
}

if (isVariantAllowed(extension, variant.name, variant.flavorName, variant.buildType)) {
Expand Down
Loading