Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## Unreleased

### Dependencies

- Bump Android SDK from v8.24.0 to v8.25.0 ([#1020](https://github.com/getsentry/sentry-android-gradle-plugin/pull/1020))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#8250)
- [diff](https://github.com/getsentry/sentry-java/compare/8.24.0...8.25.0)

## 6.0.0-alpha.6

### Dependencies
Expand Down
2 changes: 1 addition & 1 deletion plugin-build/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ org.gradle.parallel=true
name = sentry-android-gradle-plugin
group = io.sentry
version = 6.0.0-alpha.6
sdk_version = 8.24.0
sdk_version = 8.25.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The AndroidOkHttpInstallStrategy's maxSupportedSentryVersion (6.x) is too low for the new sdk_version (8.x), preventing sentry-android-okhttp auto-installation.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The AndroidOkHttpInstallStrategy defines maxSupportedSentryVersion as SemVer(6, 9999, 9999). When the sdk_version is updated to 8.25.0, the AbstractInstallStrategy's check sentrySemVersion > maxSupportedSentryVersion evaluates to true (8.25.0 > 6.9999.9999). This condition causes the sentry-android-okhttp module to be silently skipped during auto-installation, leading to missing integration and potential runtime errors when using OkHttp with Sentry.

💡 Suggested Fix

Update maxSupportedSentryVersion in AndroidOkHttpInstallStrategy.kt to reflect compatibility with Sentry SDK version 8.x or higher, or remove the maxSupportedSentryVersion override if it's no longer necessary.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: plugin-build/gradle.properties#L11

Potential issue: The `AndroidOkHttpInstallStrategy` defines `maxSupportedSentryVersion`
as `SemVer(6, 9999, 9999)`. When the `sdk_version` is updated to 8.25.0, the
`AbstractInstallStrategy`'s check `sentrySemVersion > maxSupportedSentryVersion`
evaluates to true (8.25.0 > 6.9999.9999). This condition causes the
`sentry-android-okhttp` module to be silently skipped during auto-installation, leading
to missing integration and potential runtime errors when using OkHttp with Sentry.

Did we get this right? 👍 / 👎 to inform future reviews.


# publication pom properties
POM_NAME=Sentry Android Gradle Plugin
Expand Down
Loading