Skip to content

fix(proguard): Fix compatibility with AGP 9.x when uploading proguard mappings#1021

Merged
romtsn merged 2 commits into5.x.xfrom
rz/fix/agp-900-compat
Nov 3, 2025
Merged

fix(proguard): Fix compatibility with AGP 9.x when uploading proguard mappings#1021
romtsn merged 2 commits into5.x.xfrom
rz/fix/agp-900-compat

Conversation

@romtsn
Copy link
Copy Markdown
Member

@romtsn romtsn commented Oct 30, 2025

📜 Description

This backports the fix for AGP 9.x introduced in this PR #974

💡 Motivation and Context

Closes #1004

💚 How did you test it?

Manually, see the output (Notice the AGP version tag that we send for telemetry):

> skipping upload.
  DEBUG   2025-10-30 15:18:34.862591 +01:00 sentry-cli version: 2.51.1, platform: "darwin", architecture: "arm64"
  INFO    2025-10-30 15:18:34.866553 +01:00 sentry-cli was invoked with the following command line: "/Users/romtsn/Workspace/sentry-android-gradle-plugin/examples/android-instrumentation-sample/build/tmp/sentry-cli-2.51.1.exe" "--log-level=debug" " "upload-proguard" "--uuid" "52720cce-6055-3283-bb84-4dc069702806" "/Users/romtsn/Workspace/sentry-android-gradle-plugin/examples/android-instrumentation-sample/build/outputs/mapping/stagingRelease/mapping.txt" "--no-upload" "--version-code" "1" "--app-id" "io.sentry.samples.instrumentation" "--version" "1.0-staging" "--org" "sentry-sdks" "--project" "sentry-android"


> Task :examples:android-instrumentation-sample:assembleRelease
DEBUG: Capturing transaction: afcd78de10794ff49329e5364ca48622
DEBUG: UncaughtExceptionHandlerIntegration removed.
INFO: Closing SentryClient.
DEBUG: Serializing object: {"transaction":"gradle build Android","start_timestamp":1761833880.740733,"timestamp":1761833915.081703,"spans":[{"start_timestamp":1761833881.246271,"timestamp":1761833881.247453,"trace_id":"2788b3d5bf2c4e009446d737830d5416","span_id":"d6255bb16bf74af5","parent_span_id":"7a3edf1b636e4218","op":"64063608_SentryGenerateIntegrationListTask_Decorated","origin":"manual","data":{"thread.name":"Execution worker Thread 6","thread.id":"2189"}},{"start_timestamp":1761833881.259219,"timestamp":1761833881.259444,"trace_id":"2788b3d5bf2c4e009446d737830d5416","span_id":"02c0ebb8aa7d4793","parent_span_id":"7a3edf1b636e4218","op":"64063608_SentryExternalDependenciesReportTaskV2_Decorated","origin":"manual","data":{"thread.name":"Execution worker Thread 7","thread.id":"2190"}},{"start_timestamp":1761833914.391574,"timestamp":1761833914.393242,"trace_id":"2788b3d5bf2c4e009446d737830d5416","span_id":"1a0dbe4fec2247ea","parent_span_id":"7a3edf1b636e4218","op":"64063608_SentryGenerateProguardUuidTask_Decorated","origin":"manual","data":{"thread.name":"Execution worker Thread 10","thread.id":"2194"}},{"start_timestamp":1761833914.396070,"timestamp":1761833914.400745,"trace_id":"2788b3d5bf2c4e009446d737830d5416","span_id":"fdc8b71f4886429f","parent_span_id":"7a3edf1b636e4218","op":"64063608_InjectSentryMetaPropertiesIntoAssetsTask_Decorated","origin":"manual","data":{"thread.name":"Execution worker Thread 10","thread.id":"2194"}},{"start_timestamp":1761833914.827621,"timestamp":1761833915.081215,"trace_id":"2788b3d5bf2c4e009446d737830d5416","span_id":"85a28245338c483f","parent_span_id":"7a3edf1b636e4218","op":"64063608_SentryUploadProguardMappingsTask_Decorated","origin":"manual","data":{"thread.name":"Execution worker Thread 7","thread.id":"2190"}}],"type":"transaction","transaction_info":{"source":"custom"},"event_id":"afcd78de10794ff49329e5364ca48622","contexts":{"runtime":{"name":"Eclipse Adoptium","version":"17.0.14"},"trace":{"trace_id":"2788b3d5bf2c4e009446d737830d5416","span_id":"7a3edf1b636e4218","op":"build","origin":"manual"}},"sdk":{"name":"sentry.java","version":"7.0.0","packages":[{"name":"maven:io.sentry:sentry","version":"7.0.0"}],"integrations":["UncaughtExceptionHandler","ShutdownHook"]},"tags":{"AGP_VERSION":"9.0.0-alpha12","includeNativeSources":"false","ignoredBuildTypes_set":"false","tracing_enabled":"true","includeSourceContext":"false","autoInstallation_enabled":"true","uploadNativeSymbols":"false","autoUpload":"false","includeDependenciesReport":"true","SDK_VERSION":"8.22.0","dexguardEnabled":"false","tracing_features":"[DATABASE, FILE_IO, OKHTTP, COMPOSE]","tracing_logcat_minLevel":"WARNING","tracing_debug":"false","tracing_forceInstrumentDependencies":"true","SENTRY_CLI_VERSION":"2.51.1","ignoredVariants_set":"false","debug":"true","GRADLE_VERSION":"8.14.2","includeProguardMapping":"true","additionalSourceDirsForSourceContext_set":"true","BUILD_SYSTEM":"gradle","tracing_logcat_enabled":"true","autoInstallation_sentryVersion":"8.22.0","autoUploadNativeSymbols":"true","autoUploadProguardMapping":"false","ignoredFlavors_set":"false","step":"64063608_SentryUploadProguardMappingsTask_Decorated"},"release":"5.12.1","environment":"Android","platform":"java","user":{"id":"sentry-sdks","ip_address":"{{auto}}"},"server_name":"192.168.0.89"}

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@romtsn romtsn merged commit 35cd5c8 into 5.x.x Nov 3, 2025
27 of 29 checks passed
@romtsn romtsn deleted the rz/fix/agp-900-compat branch November 3, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants