fix(proguard): Fix task ordering for proguard UUID generation with configuration cache#1050
Closed
fix(proguard): Fix task ordering for proguard UUID generation with configuration cache#1050
Conversation
runningcode
approved these changes
Jan 9, 2026
Contributor
runningcode
left a comment
There was a problem hiding this comment.
Just had some questions but otherwise looks good! Nice digging here!
| "Generates a unique build ID to be used " + "when uploading the Sentry mapping file" | ||
| } | ||
|
|
||
| @get:Internal |
Contributor
There was a problem hiding this comment.
I wonder why this is internal.
| val proguardMappingFileHash = | ||
| proguardMappingFiles.files.joinToString { if (it.isFile) it.contentHash() else STATIC_HASH } | ||
| val uuid = UUID.nameUUIDFromBytes(proguardMappingFileHash.toByteArray()) | ||
| // SentryUploadProguardMappingsTask also picks up the first existing mapping file, so there's |
Contributor
There was a problem hiding this comment.
Is the proguardMappingFiles in the same order for this task and that task?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix task ordering for proguard UUID generation with configuration cache.
AGP74Compat.ktto preserve task dependencies from AGP's artifact API@Internalto@InputFilesso Gradle properly orders the task after minification💡 Motivation and Context
Multiple customer reports internally. I wasn't able to reproduce this consistently, sadly.
Race condition where SentryGenerateProguardUuidTask could run before the mapping file is created (observed with configuration cache + AGP 8.13.2 + Kotlin 2.3.0), resulting in a stale/mismatched UUID.
Root cause:
@Internalon proguardMappingFiles prevented Gradle from inferring task dependencies and properly serializing this as part of configuration cacheproject.provider { x.get() }) broke AGP's artifact task-dependency chain💚 How did you test it?
regenerates UUID if mapping file changesanddoes not regenerate UUID every buildtests cover the behavior📝 Checklist
🔮 Next steps
N/A