Fix SentryCliVersionValueSource to respect custom URL parameter#1057
Closed
Fix SentryCliVersionValueSource to respect custom URL parameter#1057
Conversation
Copilot
AI
changed the title
[WIP] Fix handling of null URL input
Fix SentryCliVersionValueSource to respect custom URL parameter
Jan 21, 2026
…ests Co-authored-by: ndmanvar <314061+ndmanvar@users.noreply.github.com>
15cf842 to
4f16a0e
Compare
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Member
|
Closing as the url is not really used in this codepath |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
SentryCliVersionValueSourcedeclared aurlparameter but never used it when executingsentry-cli --version. Self-hosted Sentry instances would always query the default SAAS endpoint for version info.Changes:
SentryCliVersionValueSource.obtain()matching the pattern inSentryCliInfoValueSource:💡 Motivation and Context
The URL parameter was passed to
SentryCliVersionValueSource(line 319) but never added to the command arguments (lines 492-500), unlike its siblingSentryCliInfoValueSourcewhich correctly handles this.💚 How did you test it?
SentryCliVersionValueSource returns version without custom URL- verifies null caseSentryCliVersionValueSource works with custom URL- verifies custom URL case📝 Checklist
🔮 Next steps
None - fix is complete and follows existing patterns.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=1536m -XX:+HeapDumpOnOutOfMemoryError -XX:+UseParallelGC -XX:+CrashOnOutOfMemoryError -Xmx4g -Dfile.encoding=UTF-8 -Duser.country(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.