-
-
Notifications
You must be signed in to change notification settings - Fork 37
fix(ci): Fallback to AGP release notes for Gradle version lookup #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+58
−15
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2cd6840
fix(ci): Fallback to AGP release notes for Gradle version lookup
romtsn d676e04
fix(ci): Format script and add Kotlin 2.3.10 for Gradle 9.5+
romtsn ddf6db3
fix(ci): Use pre-release key for Kotlin 2.3.10 Gradle mapping
romtsn 079ba77
fix(ci): Try Kotlin 2.3.0 for Gradle 9.5+
romtsn 2a5d322
fix(ci): Dynamically set Kotlin language version based on compiler
romtsn f36ff24
fix(ci): Continue searching tables when version parse fails in releas…
romtsn 9a53589
fix(ci): Validate table headers and match exact "Gradle" cell in rele…
romtsn e0f8495
compile against a static AGP version
romtsn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flat version encoding breaks for minor versions ≥ 10
Low Severity
The flat encoding
major * 10 + minorand subsequent decode viaoldestFlat / 10andoldestFlat % 10is ambiguous when minor version reaches 10 or above. For example, if the computedoldestFlatis 30, it decodes toKOTLIN_3_0instead of the intendedKOTLIN_2_10. This would causeKotlinVersion.valueOfto throw anIllegalArgumentExceptionat configuration time. The earliest this manifests is if Kotlin reaches 2.13 (where oldest = 2.10, flat = 30 → incorrectly decoded as 3.0).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think kotlin ever reaches 10, they usually bump the major version then