Skip to content

feat(snapshot): Make Paparazzi theme configurable #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 1 commit into from
Mar 31, 2026
Merged

feat(snapshot): Make Paparazzi theme configurable #1134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/GenerateSnapshotTestsTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import org.gradle.api.provider.ListProperty
import org.gradle.api.provider.Property
import org.gradle.api.tasks.CacheableTask
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.Optional
import org.gradle.api.tasks.OutputDirectory
import org.gradle.api.tasks.TaskAction
import org.gradle.api.tasks.TaskProvider
Expand All @@ -27,6 +28,8 @@ abstract class GenerateSnapshotTestsTask : DefaultTask() {

@get:Input abstract val packageTrees: ListProperty<String>

@get:Input @get:Optional abstract val theme: Property<String>

@get:OutputDirectory abstract val outputDir: DirectoryProperty

@TaskAction
Expand All @@ -43,6 +46,7 @@ abstract class GenerateSnapshotTestsTask : DefaultTask() {
generateTestFileContent(
includePrivatePreviews = includePrivatePreviews.get(),
packageTrees = packageTrees.get(),
theme = theme.orNull,
)
File(packageDir, "$CLASS_NAME.kt").writeText(content)
logger.lifecycle("Generated snapshot test: ${packageDir.absolutePath}/$CLASS_NAME.kt")
Expand All @@ -63,6 +67,7 @@ abstract class GenerateSnapshotTestsTask : DefaultTask() {
GenerateSnapshotTestsTask::class.java,
) { task ->
task.includePrivatePreviews.set(extension.includePrivatePreviews)
task.theme.set(extension.theme)
// Fall back to the Android namespace when the user doesn't configure packageTrees
task.packageTrees.set(
extension.packageTrees.map { packages ->
Expand All @@ -79,6 +84,7 @@ abstract class GenerateSnapshotTestsTask : DefaultTask() {
private fun generateTestFileContent(
includePrivatePreviews: Boolean,
packageTrees: List<String>,
theme: String? = null,
): String {
val includePrivateExpr =
if (includePrivatePreviews) "\n .includePrivatePreviews()" else ""
Expand Down Expand Up @@ -221,7 +227,7 @@ private object PaparazziPreviewRule {
return Paparazzi(
environment = detectEnvironment().copy(compileSdkVersion = previewApiLevel),
deviceConfig = DeviceConfigBuilder.build(preview.previewInfo),
theme = "android:Theme.Translucent.NoTitleBar",
${if (theme != null) "theme = \"$theme\"," else ""}
supportsRtl = true,
showSystemUi = previewInfo.showSystemUi,
renderingMode = when {
Expand Down
2 changes: 2 additions & 0 deletions plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/SentrySnapshotExtension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,6 @@ abstract class SentrySnapshotExtension(objects: ObjectFactory) {

val packageTrees: ListProperty<String> =
objects.listProperty(String::class.java).convention(emptyList())

val theme: Property<String> = objects.property(String::class.java)
}
Loading