fix(snapshots): Use snake_case for sidecar metadata JSON keys#1157
Merged
runningcode merged 1 commit intomainfrom Apr 21, 2026
Merged
fix(snapshots): Use snake_case for sidecar metadata JSON keys#1157runningcode merged 1 commit intomainfrom
runningcode merged 1 commit intomainfrom
Conversation
Normalize all keys in the per-snapshot sidecar metadata JSON to snake_case. Previously only `display_name` and `image_file_name` were snake_case while the remaining ten keys used camelCase, forcing downstream consumers to handle both conventions.
runningcode
requested review from
adinauer,
chromy,
markushi,
rbro112 and
romtsn
as code owners
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
romtsn
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize every key in the per-snapshot sidecar metadata JSON to snake_case. Previously only
display_nameandimage_file_namewere snake_case while the other ten keys (className,methodName,previewName,nightMode,fontScale,apiLevel,widthDp,heightDp,showSystemUi,showBackground) used camelCase, forcing downstream consumers to handle both conventions.#skip-changelog (None of the snapshot features are mentioned in the changelog)