From f3f336f40a36ecc212c4f6955cce73f99fca816b Mon Sep 17 00:00:00 2001 From: Nelson Osacky Date: Tue, 21 Apr 2026 11:35:52 +0200 Subject: [PATCH] fix(snapshots): Use snake_case for sidecar metadata JSON keys Normalize all keys in the per-snapshot sidecar metadata JSON to snake_case. Previously only `display_name` and `image_file_name` were snake_case while the remaining ten keys used camelCase, forcing downstream consumers to handle both conventions. --- .../snapshot/GenerateSnapshotTestsTask.kt | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/GenerateSnapshotTestsTask.kt b/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/GenerateSnapshotTestsTask.kt index 25eb9df0..b1ccf329 100644 --- a/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/GenerateSnapshotTestsTask.kt +++ b/plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/GenerateSnapshotTestsTask.kt @@ -361,20 +361,20 @@ class $CLASS_NAME( val metadata = linkedMapOf( "display_name" to screenshotId.removePrefix(preview.declaringClass + "."), "image_file_name" to screenshotId, - "className" to preview.declaringClass, - "methodName" to preview.methodName, + "class_name" to preview.declaringClass, + "method_name" to preview.methodName, ) if (info.group.isNotBlank()) metadata["group"] = info.group - if (info.name.isNotBlank()) metadata["previewName"] = info.name + if (info.name.isNotBlank()) metadata["preview_name"] = info.name if (info.locale.isNotBlank()) metadata["locale"] = info.locale if (info.device.isNotBlank()) metadata["device"] = info.device - metadata["nightMode"] = (info.uiMode and UI_MODE_NIGHT_MASK == UI_MODE_NIGHT_YES) - if (info.fontScale != 1f) metadata["fontScale"] = info.fontScale - if (info.apiLevel != -1) metadata["apiLevel"] = info.apiLevel - if (info.widthDp > 0) metadata["widthDp"] = info.widthDp - if (info.heightDp > 0) metadata["heightDp"] = info.heightDp - if (info.showSystemUi) metadata["showSystemUi"] = true - if (info.showBackground) metadata["showBackground"] = true + metadata["night_mode"] = (info.uiMode and UI_MODE_NIGHT_MASK == UI_MODE_NIGHT_YES) + if (info.fontScale != 1f) metadata["font_scale"] = info.fontScale + if (info.apiLevel != -1) metadata["api_level"] = info.apiLevel + if (info.widthDp > 0) metadata["width_dp"] = info.widthDp + if (info.heightDp > 0) metadata["height_dp"] = info.heightDp + if (info.showSystemUi) metadata["show_system_ui"] = true + if (info.showBackground) metadata["show_background"] = true val json = metadata.entries.joinToString(",\n ", prefix = "{\n ", postfix = "\n}") { (k, v) -> if (v is String) "\"" + k + "\": \"" + escapeJson(v) + "\""