Skip to content

fix(snapshots): Use snake_case for sidecar metadata JSON keys #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 1 commit into from
Apr 21, 2026
+10 −10
Merged

fix(snapshots): Use snake_case for sidecar metadata JSON keys #1157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions plugin-build/src/main/kotlin/io/sentry/android/gradle/snapshot/GenerateSnapshotTestsTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,20 +361,20 @@ class $CLASS_NAME(
val metadata = linkedMapOf<String, Any>(
"display_name" to screenshotId.removePrefix(preview.declaringClass + "."),
"image_file_name" to screenshotId,
"className" to preview.declaringClass,
"methodName" to preview.methodName,
"class_name" to preview.declaringClass,
"method_name" to preview.methodName,
)
if (info.group.isNotBlank()) metadata["group"] = info.group
if (info.name.isNotBlank()) metadata["previewName"] = info.name
if (info.name.isNotBlank()) metadata["preview_name"] = info.name
if (info.locale.isNotBlank()) metadata["locale"] = info.locale
if (info.device.isNotBlank()) metadata["device"] = info.device
metadata["nightMode"] = (info.uiMode and UI_MODE_NIGHT_MASK == UI_MODE_NIGHT_YES)
if (info.fontScale != 1f) metadata["fontScale"] = info.fontScale
if (info.apiLevel != -1) metadata["apiLevel"] = info.apiLevel
if (info.widthDp > 0) metadata["widthDp"] = info.widthDp
if (info.heightDp > 0) metadata["heightDp"] = info.heightDp
if (info.showSystemUi) metadata["showSystemUi"] = true
if (info.showBackground) metadata["showBackground"] = true
metadata["night_mode"] = (info.uiMode and UI_MODE_NIGHT_MASK == UI_MODE_NIGHT_YES)
if (info.fontScale != 1f) metadata["font_scale"] = info.fontScale
if (info.apiLevel != -1) metadata["api_level"] = info.apiLevel
if (info.widthDp > 0) metadata["width_dp"] = info.widthDp
if (info.heightDp > 0) metadata["height_dp"] = info.heightDp
if (info.showSystemUi) metadata["show_system_ui"] = true
if (info.showBackground) metadata["show_background"] = true

val json = metadata.entries.joinToString(",\n ", prefix = "{\n ", postfix = "\n}") { (k, v) ->
if (v is String) "\"" + k + "\": \"" + escapeJson(v) + "\""
Expand Down
Loading