refactor: Inject ObjectFactory instead of Project in SentryPluginExtension#1181
Merged
runningcode merged 1 commit intomainfrom May 6, 2026
Merged
refactor: Inject ObjectFactory instead of Project in SentryPluginExtension#1181runningcode merged 1 commit intomainfrom
runningcode merged 1 commit intomainfrom
Conversation
…nsion SentryPluginExtension only used Project to get ObjectFactory. Injecting ObjectFactory directly removes the unnecessary Project dependency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
runningcode
requested review from
adinauer,
chromy,
markushi,
rbro112 and
romtsn
as code owners
Contributor
Author
|
The windows failure seems to be a temporary server issue in downloading the CLI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SentryPluginExtensiononly usedProjectto callproject.objects— injectObjectFactorydirectly insteadProjectdependency from the extension constructor#skip-changelog
🤖 Generated with Claude Code