Skip to content

fix(instrumentation): Make SentryGenerateIntegrationListTask configuration-cache compatible#866

Merged
romtsn merged 4 commits intomainfrom
rz/fix/integration-list-task-config-cache
Apr 23, 2025
Merged

fix(instrumentation): Make SentryGenerateIntegrationListTask configuration-cache compatible#866
romtsn merged 4 commits intomainfrom
rz/fix/integration-list-task-config-cache

Conversation

@romtsn
Copy link
Copy Markdown
Member

@romtsn romtsn commented Apr 22, 2025

📜 Description

The task inputs were not properly wired, so running with config-cache enabled resulted in inconsistent integrations list being written to the manifest + unnecessary task reruns. Using flatMap on the input + returning a Provider from SentryModulesService fixes the problem.

💡 Motivation and Context

Fixes #846

💚 How did you test it?

Manually + automated

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@romtsn romtsn changed the title fix: Make SentryGenerateIntegrationListTask configuration-cache compatible fix(instrumentation): Make SentryGenerateIntegrationListTask configuration-cache compatible Apr 22, 2025
@romtsn romtsn merged commit 57e53d5 into main Apr 23, 2025
23 checks passed
@romtsn romtsn deleted the rz/fix/integration-list-task-config-cache branch April 23, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SentryGenerateIntegrationListTask works unstable if configuration cache is enabled

2 participants