-
-
Notifications
You must be signed in to change notification settings - Fork 37
ci(agp-matrix): Generate compatibility matrix dynamically #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
fd371c0
ci(agp-matrix): Generate compatibility matrix dynamically
romtsn a78c757
fix script filename
romtsn 21c1a20
WIP
romtsn 9480fb1
WIP
romtsn 1de2b3d
WIP
romtsn 329b1de
WIP
romtsn 8b1e591
WIP
romtsn 8d508ba
WIP
romtsn bc63a3e
WIP
romtsn 979027a
WIP
romtsn f4efcb9
WIP
romtsn f1657b1
WIP
romtsn de161f2
WIP
romtsn 948f478
WIP
romtsn 71223b8
WIP
romtsn 53471fd
WIP
romtsn a82cc46
WIP
romtsn 6e7c4a0
Works?
romtsn 4499ad1
Change name
romtsn 7e88c31
Switch to ksp for room
romtsn 701e1c0
Override version check for tests
romtsn a955abd
Merge branch 'main' into rz/ci/generate-compat-matrix
romtsn e353f6c
Merge branch 'main' into rz/ci/generate-compat-matrix
romtsn 9c12688
Merge branch 'main' into rz/ci/generate-compat-matrix
romtsn 4ac83d0
also fetch kotlin-gradle compatibility and use the min supported grad…
romtsn f712f1e
Matrix only last line of the script output
romtsn d693476
Changelog
romtsn a11cf74
Run test matrix nightly
romtsn acc1dac
Minor comments
romtsn 9bbf39c
Update .github/workflows/test-matrix-agp-gradle.yaml
romtsn 03f58ef
Update scripts/generate-compat-matrix.main.kts
romtsn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ kotlin = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" } | |
| kotlinAndroid = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" } | ||
| kotlinSpring = { id = "org.jetbrains.kotlin.plugin.spring", version.ref = "kotlin" } | ||
| kapt = { id = "org.jetbrains.kotlin.kapt", version.ref = "kotlin" } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we still need kapt?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yep, it's used in the compiler plugin for AutoService |
||
| ksp = { id = "com.google.devtools.ksp", version = "1.8.20-1.0.11" } | ||
| dokka = { id = "org.jetbrains.dokka", version = "1.8.10" } | ||
| spotless = { id = "com.diffplug.spotless", version = "7.0.4" } | ||
| groovyGradlePlugin = { id = "dev.gradleplugins.groovy-gradle-plugin", version = "1.7.1" } | ||
|
|
@@ -77,7 +78,6 @@ sample-coroutines-android = { group = "org.jetbrains.kotlinx", name = "kotlinx-c | |
| sample-room-runtime = { group = "androidx.room", name = "room-runtime", version.ref = "sampleRoom" } | ||
| sample-room-ktx = { group = "androidx.room", name = "room-ktx", version.ref = "sampleRoom" } | ||
| sample-room-compiler = { group = "androidx.room", name = "room-compiler", version.ref = "sampleRoom" } | ||
| sample-room-rxjava = { group = "androidx.room", name = "room-rxjava2", version.ref = "sampleRoom" } | ||
|
|
||
| sample-retrofit-retrofit = { group = "com.squareup.retrofit2", name = "retrofit", version.ref = "sampleRetrofit" } | ||
| sample-retrofit-retrofitGson = { group = "com.squareup.retrofit2", name = "converter-gson", version.ref = "sampleRetrofit" } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly does this do? It seems to me that it checks that the running Gradle version is compatible with AGP version?
Why do we need this in the parent build? Is it just while we are running the entire build with different versions of Gradle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep that's the reason! Was failing here without that flag: https://github.com/getsentry/sentry-android-gradle-plugin/actions/runs/14733865730/job/41354917196?pr=873