FIX: missing ip settings from SDK package#957
Conversation
antonis
left a comment
There was a problem hiding this comment.
Awesome work @lucas-zimerman 🚀
The changes LGTM. Thank you adding unit test and test data in the comments.
Added a couple of questions but nothing blocking.
There was a problem hiding this comment.
Thanks for fixing this! Looks good to me!
I'm thinking that the SDK might still set user.ip_address: '{{auto}}' in case setDefaultPii: true. In case it does, we could still still clean this up but it's not the end of the world either way. sdk.settings.infer_ip overrules the other field in both cases.
I have removed the auto ip here 49d6b67 |
|
PR test error is unrelated to the added code and will be fixed on another PR |

Based on getsentry/sentry-javascript#17364
original context;
Instead of bumping o V10, the fix was patched on the current release.