-
-
Notifications
You must be signed in to change notification settings - Fork 248
Expand file tree
/
Copy pathbundle_jvm.rs
More file actions
241 lines (216 loc) · 7.84 KB
/
Copy pathbundle_jvm.rs
File metadata and controls
241 lines (216 loc) · 7.84 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
#![expect(clippy::unwrap_used, reason = "contains legacy code which uses unwrap")]
use crate::config::Config;
use crate::utils::args::ArgExt as _;
use crate::utils::file_search::ReleaseFileSearch;
use crate::utils::file_upload::SourceFile;
use crate::utils::fs::path_as_url;
use crate::utils::source_bundle::{self, BundleContext};
use anyhow::{bail, Context as _, Result};
use clap::{Arg, ArgAction, ArgMatches, Command};
use log::debug;
use sentry::types::DebugId;
use std::borrow::Cow;
use std::collections::BTreeMap;
use std::ffi::OsStr;
use std::fs;
use std::path::{Path, PathBuf};
use std::str::FromStr as _;
use std::sync::Arc;
use symbolic::debuginfo::sourcebundle::SourceFileType;
/// File extensions for JVM-based languages.
const JVM_EXTENSIONS: &[&str] = &[
"java", "kt", "scala", "sc", "groovy", "gvy", "gy", "gsh", "clj", "cljc",
];
/// Directory patterns that are always safe to exclude globally (can never be
/// valid JVM package names due to leading dots or conventions).
const SAFE_EXCLUDES: &[&str] = &[
"!.cxx",
"!.eclipse",
"!.fleet",
"!.gradle",
"!.idea",
"!.kotlin",
"!.mvn",
"!.settings",
"!.vscode",
"!node_modules",
];
/// Directory names that are common build output dirs but could also be valid
/// JVM package names (e.g. `com.example.build`). These are only excluded when
/// they appear outside of `src/` directories to avoid filtering out legitimate
/// source packages.
const AMBIGUOUS_EXCLUDES: &[&str] = &["bin", "build", "out", "target"];
/// Returns true if `path` has a `src` ancestor before the given directory name.
/// E.g. `src/main/java/com/example/build/Foo.java` → true (under src/).
/// E.g. `app/build/generated/Foo.java` → false (not under src/).
fn is_under_src(relative_path: &Path) -> bool {
relative_path
.ancestors()
.any(|a| a.file_name() == Some(OsStr::new("src")))
}
/// Returns true if the file should be excluded because it sits inside an
/// ambiguous build-output directory that is NOT under a `src/` ancestor.
fn is_in_ambiguous_build_dir(relative_path: &Path) -> bool {
for ancestor in relative_path.ancestors() {
let Some(name) = ancestor.file_name().and_then(|n| n.to_str()) else {
continue;
};
if AMBIGUOUS_EXCLUDES.contains(&name) {
return !is_under_src(relative_path);
}
}
false
}
pub fn make_command(command: Command) -> Command {
command
.hide(true) // experimental for now
.about(
"Create a source bundle for the given JVM based source files (e.g. Java, Kotlin, ...)",
)
.org_arg()
.project_arg(false)
.arg(
Arg::new("path")
.value_name("PATH")
.required(true)
.value_parser(clap::builder::PathBufValueParser::new())
.help("The directory containing source files to bundle."),
)
.arg(
Arg::new("output")
.long("output")
.value_name("PATH")
.required(true)
.value_parser(clap::builder::PathBufValueParser::new())
.help("The path to the output folder."),
)
.arg(
Arg::new("debug_id")
.long("debug-id")
.value_name("UUID")
.required(true)
.value_parser(DebugId::from_str)
.help("Debug ID (UUID) to use for the source bundle."),
)
.arg(
Arg::new("exclude")
.long("exclude")
.value_name("PATTERN")
.action(ArgAction::Append)
.help(
"Glob pattern to exclude files/directories. Can be repeated. \
By default, common build output and IDE directories are excluded \
(build, .gradle, target, .idea, .vscode, out, bin, etc.).",
),
)
}
pub fn execute(matches: &ArgMatches) -> Result<()> {
let config = Config::current();
let org = config.get_org(matches)?;
let project = config.get_project(matches).ok();
let context = BundleContext::new(&org).with_projects(project.as_slice());
let path = matches.get_one::<PathBuf>("path").unwrap();
let output_path = matches.get_one::<PathBuf>("output").unwrap();
let debug_id = matches.get_one::<DebugId>("debug_id").unwrap();
let out = output_path.join(format!("{debug_id}.zip"));
if !path.exists() {
bail!("Given path does not exist: {}", path.display())
}
if !path.is_dir() {
bail!("Given path is not a directory: {}", path.display())
}
if !output_path.exists() {
fs::create_dir_all(output_path).context(format!(
"Failed to create output directory {}",
output_path.display()
))?;
}
let user_excludes = matches
.get_many::<String>("exclude")
.into_iter()
.flatten()
.map(|v| format!("!{v}"));
let all_excludes = SAFE_EXCLUDES
.iter()
.copied()
.map(Cow::Borrowed)
.chain(user_excludes.map(Cow::Owned));
let sources = ReleaseFileSearch::new(path.clone())
.extensions(JVM_EXTENSIONS.iter().copied())
.ignores(all_excludes)
.respect_ignores(true)
.collect_files()?;
let sources: Vec<_> = sources
.into_iter()
.filter(|source| {
let relative = source.path.strip_prefix(&source.base_path).unwrap();
if is_in_ambiguous_build_dir(relative) {
debug!("excluding (build output): {}", source.path.display());
return false;
}
true
})
.collect();
let files = sources.iter().map(|source| {
let local_path = source.path.strip_prefix(&source.base_path).unwrap();
let local_path_jvm_ext = local_path.with_extension("jvm");
let url = format!("~/{}", path_as_url(&local_path_jvm_ext));
SourceFile {
url,
path: source.path.clone(),
contents: Arc::new(source.contents.clone()),
ty: SourceFileType::Source,
headers: BTreeMap::new(),
messages: vec![],
already_uploaded: false,
}
});
let tempfile = source_bundle::build(context, files, Some(*debug_id))
.context("Unable to create source bundle")?;
fs::copy(tempfile.path(), &out).context("Unable to write source bundle")?;
println!("Created {}", out.display());
Ok(())
}
#[cfg(test)]
mod tests {
use super::*;
use std::path::Path;
#[test]
fn test_excludes_build_output_at_module_root() {
assert!(is_in_ambiguous_build_dir(Path::new(
"app/build/generated/Foo.java"
)));
assert!(is_in_ambiguous_build_dir(Path::new(
"build/generated/Foo.java"
)));
assert!(is_in_ambiguous_build_dir(Path::new(
"module/target/classes/Foo.java"
)));
assert!(is_in_ambiguous_build_dir(Path::new("bin/Foo.class")));
assert!(is_in_ambiguous_build_dir(Path::new(
"out/production/Foo.java"
)));
}
#[test]
fn test_keeps_source_packages_under_src() {
assert!(!is_in_ambiguous_build_dir(Path::new(
"src/main/java/com/example/build/Builder.java"
)));
assert!(!is_in_ambiguous_build_dir(Path::new(
"app/src/main/java/com/example/target/Target.java"
)));
assert!(!is_in_ambiguous_build_dir(Path::new(
"src/main/kotlin/com/example/out/Output.kt"
)));
}
#[test]
fn test_keeps_files_without_ambiguous_dirs() {
assert!(!is_in_ambiguous_build_dir(Path::new(
"src/main/java/com/example/Foo.java"
)));
assert!(!is_in_ambiguous_build_dir(Path::new("Foo.java")));
assert!(!is_in_ambiguous_build_dir(Path::new(
"app/src/main/java/Foo.java"
)));
}
}