improve

Author: lcian

src/api/data_types/mod.rs

@@ -2,6 +2,8 @@
 
 mod chunking;
 mod deploy;
+mod snapshots;
 
 pub use self::chunking::*;
 pub use self::deploy::*;
+pub use self::snapshots::*;

src/api/data_types/snapshots.rs

@@ -0,0 +1,30 @@
+//! Data types for the snapshots API.
+
+use std::collections::HashMap;
+
+use serde::{Deserialize, Serialize};
+
+/// Response from the create snapshot endpoint.
+#[derive(Debug, Deserialize)]
+#[serde(rename_all = "camelCase")]
+pub struct CreateSnapshotResponse {
+    pub artifact_id: String,
+    pub image_count: u64,
+}
+
+// Keep in sync with https://github.com/getsentry/sentry/blob/master/src/sentry/preprod/snapshots/manifest.py
+/// Manifest describing a set of snapshot images for an app.
+#[derive(Debug, Serialize)]
+pub struct SnapshotsManifest {
+    pub app_id: String,
+    pub images: HashMap<String, ImageMetadata>,
+}
+
+// Keep in sync with https://github.com/getsentry/sentry/blob/master/src/sentry/preprod/snapshots/manifest.py
+/// Metadata for a single image in a snapshot manifest.
+#[derive(Debug, Serialize)]
+pub struct ImageMetadata {
+    pub image_file_name: String,
+    pub width: u32,
+    pub height: u32,
+}

src/commands/build/snapshots.rs

@@ -8,13 +8,12 @@ use clap::{Arg, ArgMatches, Command};
 use console::style;
 use log::{debug, info, warn};
 use objectstore_client::{ClientBuilder, ExpirationPolicy, Usecase};
-use serde::{Deserialize, Serialize};
 use sha2::{Digest as _, Sha256};
 use walkdir::WalkDir;
 
 use secrecy::ExposeSecret as _;
 
-use crate::api::Api;
+use crate::api::{Api, CreateSnapshotResponse, ImageMetadata, SnapshotsManifest};
 use crate::config::{Auth, Config};
 use crate::utils::args::ArgExt as _;
 
@@ -47,28 +46,6 @@ pub fn make_command(command: Command) -> Command {
         )
 }
 
-#[derive(Deserialize)]
-#[serde(rename_all = "camelCase")]
-struct CreateSnapshotResponse {
-    artifact_id: String,
-    image_count: u64,
-}
-
-// Keep in sync with https://github.com/getsentry/sentry/blob/master/src/sentry/preprod/snapshots/manifest.py
-#[derive(Serialize)]
-struct SnapshotsManifest {
-    app_id: String,
-    images: HashMap<String, ImageMetadata>,
-}
-
-// Keep in sync with https://github.com/getsentry/sentry/blob/master/src/sentry/preprod/snapshots/manifest.py
-#[derive(Serialize)]
-struct ImageMetadata {
-    image_file_name: String,
-    width: u32,
-    height: u32,
-}
-
 struct ImageInfo {
     path: std::path::PathBuf,
     relative_path: String,