fix(build): Check xcarchive/IPA extension before ByteView::open

ByteView::open() calls File::open() internally, which fails with a
generic I/O error on directories. Since .xcarchive is a directory
bundle, the previous validation in validate_is_supported_build() was
unreachable — users on non-Apple Silicon got a confusing "Is a
directory" error instead of the intended helpful message.

Move the extension check before ByteView::open() so the clear error
message is shown.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: runningcode

src/commands/build/upload.rs

@@ -209,6 +209,20 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
             return Err(anyhow!("Path does not exist: {}", path.display()));
         }
 
+        // On non-Apple Silicon, reject xcarchive/IPA early before trying to
+        // open the path as a file (xcarchive is a directory, so ByteView::open
+        // would fail with a confusing I/O error).
+        #[cfg(not(all(target_os = "macos", target_arch = "aarch64")))]
+        {
+            let ext = path.extension().and_then(|e| e.to_str()).unwrap_or("");
+            if ext.eq_ignore_ascii_case("xcarchive") || ext.eq_ignore_ascii_case("ipa") {
+                return Err(anyhow!(
+                    "Uploading XCArchive and IPA files requires an Apple Silicon Mac: {}",
+                    path.display()
+                ));
+            }
+        }
+
         let byteview = ByteView::open(path)?;
         debug!("Loaded file with {} bytes", byteview.len());
 
@@ -543,17 +557,6 @@ fn validate_is_supported_build(path: &Path, bytes: &[u8]) -> Result<()> {
 
     debug!("File format validation failed");
 
-    #[cfg(not(all(target_os = "macos", target_arch = "aarch64")))]
-    {
-        let ext = path.extension().and_then(|e| e.to_str()).unwrap_or("");
-        if ext.eq_ignore_ascii_case("xcarchive") || ext.eq_ignore_ascii_case("ipa") {
-            return Err(anyhow!(
-                "Uploading XCArchive and IPA files requires an Apple Silicon Mac: {}",
-                path.display()
-            ));
-        }
-    }
-
     #[cfg(all(target_os = "macos", target_arch = "aarch64"))]
     let format_list = "APK, AAB, XCArchive, or IPA";
     #[cfg(not(all(target_os = "macos", target_arch = "aarch64")))]