ref: Enable str-to-string lint

Primarily to maintain a consistent style for converting `&str` to `String`.

Author: szokeasaurusrex

Cargo.toml

@@ -100,6 +100,7 @@ unstable-mobile-app = ["apple-catalog-parsing"]
 
 [workspace.lints.clippy]
 allow-attributes = "warn"
+str-to-string = "warn"
 unnecessary-wraps = "warn"
 unwrap-used = "warn"
 

apple-catalog-parsing/build.rs

@@ -89,7 +89,7 @@ fn main() {
     let developer_dir_path = String::from_utf8(developer_dir.stdout)
         .expect("Failed to convert developer directory to UTF-8")
         .trim()
-        .to_string();
+        .to_owned();
 
     println!(
         "cargo:rustc-link-search={developer_dir_path}/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx"

src/api/mod.rs

@@ -473,7 +473,7 @@ impl<'a> AuthenticatedApi<'a> {
         checksums: &[String],
     ) -> ApiResult<Vec<Artifact>> {
         let mut rv = vec![];
-        let mut cursor = "".to_string();
+        let mut cursor = "".to_owned();
         loop {
             let mut path = if let Some(project) = project {
                 format!(
@@ -1080,7 +1080,7 @@ impl<'a> AuthenticatedApi<'a> {
     /// we're issuing a request to a monolith deployment.
     pub fn list_organizations(&self, region: Option<&Region>) -> ApiResult<Vec<Organization>> {
         let mut rv = vec![];
-        let mut cursor = "".to_string();
+        let mut cursor = "".to_owned();
         loop {
             let current_path = &format!("/organizations/?cursor={}", QueryArg(&cursor));
             let resp = if let Some(rg) = region {
@@ -1128,7 +1128,7 @@ impl<'a> AuthenticatedApi<'a> {
     /// List all monitors associated with an organization
     pub fn list_organization_monitors(&self, org: &str) -> ApiResult<Vec<Monitor>> {
         let mut rv = vec![];
-        let mut cursor = "".to_string();
+        let mut cursor = "".to_owned();
         loop {
             let resp = self.get(&format!(
                 "/organizations/{}/monitors/?cursor={}",
@@ -1156,7 +1156,7 @@ impl<'a> AuthenticatedApi<'a> {
     /// List all projects associated with an organization
     pub fn list_organization_projects(&self, org: &str) -> ApiResult<Vec<Project>> {
         let mut rv = vec![];
-        let mut cursor = "".to_string();
+        let mut cursor = "".to_owned();
         loop {
             let resp = self.get(&format!(
                 "/organizations/{}/projects/?cursor={}",
@@ -1189,7 +1189,7 @@ impl<'a> AuthenticatedApi<'a> {
         max_pages: usize,
     ) -> ApiResult<Vec<ProcessedEvent>> {
         let mut rv = vec![];
-        let mut cursor = "".to_string();
+        let mut cursor = "".to_owned();
         let mut requests_no = 0;
 
         loop {
@@ -1236,7 +1236,7 @@ impl<'a> AuthenticatedApi<'a> {
         query: Option<String>,
     ) -> ApiResult<Vec<Issue>> {
         let mut rv = vec![];
-        let mut cursor = "".to_string();
+        let mut cursor = "".to_owned();
         let mut requests_no = 0;
 
         let url = if let Some(query) = query {
@@ -1283,7 +1283,7 @@ impl<'a> AuthenticatedApi<'a> {
     /// List all repos associated with an organization
     pub fn list_organization_repos(&self, org: &str) -> ApiResult<Vec<Repo>> {
         let mut rv = vec![];
-        let mut cursor = "".to_string();
+        let mut cursor = "".to_owned();
         loop {
             let path = format!(
                 "/organizations/{}/repos/?cursor={}",
@@ -1930,7 +1930,7 @@ fn log_headers(is_response: bool, data: &[u8]) {
 
             let replaced = AUTH_RE.replace_all(line, |caps: &Captures<'_>| {
                 let info = if &caps[1].to_lowercase() == "basic" {
-                    caps[3].split(':').next().unwrap().to_string()
+                    caps[3].split(':').next().unwrap().to_owned()
                 } else {
                     format!("{}***", &caps[3][..std::cmp::min(caps[3].len(), 8)])
                 };

src/api/pagination.rs

@@ -33,7 +33,7 @@ impl FromStr for Pagination {
 
             *target = Some(Link {
                 results: item.get("results") == Some(&"true"),
-                cursor: (*item.get("cursor").unwrap_or(&"")).to_string(),
+                cursor: (*item.get("cursor").unwrap_or(&"")).to_owned(),
             });
         }
 

src/commands/bash_hook.rs

@@ -117,7 +117,7 @@ fn send_event(
         );
     }
 
-    let mut cmd = "unknown".to_string();
+    let mut cmd = "unknown".to_owned();
     let mut exit_code = 1;
     let mut frames = vec![];
 
@@ -129,7 +129,7 @@ fn send_event(
             // meta info
             if line.starts_with('@') {
                 if let Some(rest) = line.strip_prefix("@command:") {
-                    cmd = rest.to_string();
+                    cmd = rest.to_owned();
                 } else if let Some(rest) = line.strip_prefix("@exit_code:") {
                     exit_code = rest.parse().unwrap_or(exit_code);
                 } else {
@@ -170,7 +170,7 @@ fn send_event(
                 if let Ok(f) = fs::File::open(filename) {
                     let lines: Vec<_> = BufReader::new(f)
                         .lines()
-                        .map(|x| x.unwrap_or_else(|_| "".to_string()))
+                        .map(|x| x.unwrap_or_else(|_| "".to_owned()))
                         .collect();
                     source_caches.insert(filename, lines);
                 } else {

src/commands/files/upload.rs

@@ -143,7 +143,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                 bail!("Invalid header. Needs to be in key:value format");
             }
             let (key, value) = header.split_once(':').unwrap();
-            headers.insert(key.trim().to_string(), value.trim().to_string());
+            headers.insert(key.trim().to_owned(), value.trim().to_owned());
         }
     };
 

src/commands/info.rs

@@ -70,7 +70,7 @@ fn get_config_status_json() -> Result<()> {
     let (org, project) = config.get_org_and_project_defaults();
     rv.config.org = org;
     rv.config.project = project;
-    rv.config.url = Some(config.get_base_url()?.to_string());
+    rv.config.url = Some(config.get_base_url()?.to_owned());
 
     rv.auth.auth_type = config.get_auth().map(|val| match val {
         Auth::Token(_) => "token".into(),

src/commands/login.rs

@@ -153,7 +153,7 @@ fn get_org_from_token(token: &AuthToken) -> Option<&str> {
 fn format_org_info(org: Option<&str>) -> String {
     match org {
         Some(org_name) => format!("for organization {org_name}"),
-        None => "not tied to any specific organization".to_string(),
+        None => "not tied to any specific organization".to_owned(),
     }
 }
 

src/commands/mod.rs

@@ -106,7 +106,7 @@ const UPDATE_NAGGER_CMDS: &[&str] = &[
 const AUTH_TOKEN_ARG: &str = "auth-token";
 
 fn print_completions<G: Generator>(gen: G, cmd: &mut Command) {
-    generate(gen, cmd, cmd.get_name().to_string(), &mut io::stdout());
+    generate(gen, cmd, cmd.get_name().to_owned(), &mut io::stdout());
 }
 
 fn preexecute_hooks() -> Result<bool> {

src/commands/monitors/run.rs

@@ -140,10 +140,10 @@ fn execute_checkin(
 
     let open_checkin = MonitorCheckIn {
         check_in_id,
-        monitor_slug: monitor_slug.to_string(),
+        monitor_slug: monitor_slug.to_owned(),
         status: MonitorCheckInStatus::InProgress,
         duration: None,
-        environment: Some(environment.to_string()),
+        environment: Some(environment.to_owned()),
         monitor_config,
     };
 
@@ -166,10 +166,10 @@ fn execute_checkin(
 
     let close_checkin = MonitorCheckIn {
         check_in_id,
-        monitor_slug: monitor_slug.to_string(),
+        monitor_slug: monitor_slug.to_owned(),
         status,
         duration,
-        environment: Some(environment.to_string()),
+        environment: Some(environment.to_owned()),
         monitor_config: None,
     };