Rename mobile-app subcommand to build

Author: rbro112

.cursor/rules/rust-development.mdc

@@ -50,7 +50,7 @@ cargo fmt
 ## Swift/Apple Integration
 
 - Swift code in `apple-catalog-parsing/` is used for parsing xarchive files
-- Used by the `mobile-app upload` command for iOS app processing
+- Used by the `build upload` command for iOS app processing
 - Built as a separate crate with FFI bindings to Rust
 - Only compiled on macOS targets
 - Tests run via `swift-test.yml` workflow in CI

src/api/data_types/chunking/mobile_app.rs src/api/data_types/chunking/build.rssrc/api/data_types/chunking/mobile_app.rs renamed to src/api/data_types/chunking/build.rs

@@ -4,7 +4,7 @@ use sha1_smol::Digest;
 use super::ChunkedFileState;
 
 #[derive(Debug, Serialize)]
-pub struct ChunkedMobileAppRequest<'a> {
+pub struct ChunkedBuildRequest<'a> {
     pub checksum: Digest,
     pub chunks: &'a [Digest],
     #[serde(skip_serializing_if = "Option::is_none")]
@@ -30,7 +30,7 @@ pub struct ChunkedMobileAppRequest<'a> {
 
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
-pub struct AssembleMobileAppResponse {
+pub struct AssembleBuildResponse {
     pub state: ChunkedFileState,
     pub missing_chunks: Vec<Digest>,
     pub detail: Option<String>,

src/api/data_types/chunking/mod.rs

@@ -2,14 +2,16 @@
 //! from the server.
 
 mod artifact;
+mod build;
 mod compression;
 mod dif;
 mod file_state;
 mod hash_algorithm;
-mod mobile_app;
 mod upload;
 
 pub use self::artifact::{AssembleArtifactsResponse, ChunkedArtifactRequest};
+#[cfg(feature = "unstable-build")]
+pub use self::build::{AssembleBuildResponse, ChunkedBuildRequest};
 pub use self::compression::ChunkCompression;
 pub use self::dif::{AssembleDifsRequest, AssembleDifsResponse, ChunkedDifRequest};
 pub use self::file_state::ChunkedFileState;

src/api/mod.rs

@@ -1038,15 +1038,15 @@ impl<'a> AuthenticatedApi<'a> {
         chunks: &[Digest],
         build_configuration: Option<&str>,
         vcs_info: &VcsInfo<'_>,
-    ) -> ApiResult<AssembleMobileAppResponse> {
+    ) -> ApiResult<AssembleBuildResponse> {
         let url = format!(
             "/projects/{}/{}/files/preprodartifacts/assemble/",
             PathArg(org),
             PathArg(project)
         );
 
         self.request(Method::Post, &url)?
-            .with_json_body(&ChunkedMobileAppRequest {
+            .with_json_body(&ChunkedBuildRequest {
                 checksum,
                 chunks,
                 build_configuration,

src/commands/mobile_app/mod.rs src/commands/build/mod.rssrc/commands/mobile_app/mod.rs renamed to src/commands/build/mod.rs

@@ -14,14 +14,14 @@ macro_rules! each_subcommand {
 pub fn make_command(mut command: Command) -> Command {
     macro_rules! add_subcommand {
         ($name:ident) => {{
-            command = command.subcommand(crate::commands::mobile_app::$name::make_command(
+            command = command.subcommand(crate::commands::build::$name::make_command(
                 Command::new(stringify!($name).replace('_', "-")),
             ));
         }};
     }
 
     command = command
-        .about("[EXPERIMENTAL] Manage mobile apps.")
+        .about("[EXPERIMENTAL] Manage builds.")
         .subcommand_required(true)
         .arg_required_else_help(true)
         .org_arg()
@@ -34,7 +34,7 @@ pub fn make_command(mut command: Command) -> Command {
 
 pub fn execute(matches: &ArgMatches) -> Result<()> {
     log::warn!(
-        "EXPERIMENTAL: The mobile-app subcommand is experimental. \
+        "EXPERIMENTAL: The build subcommand is experimental. \
         The command is subject to breaking changes and may be removed \
         without notice in any release."
     );
@@ -44,7 +44,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
             if let Some(sub_matches) =
                 matches.subcommand_matches(&stringify!($name).replace('_', "-"))
             {
-                return crate::commands::mobile_app::$name::execute(&sub_matches);
+                return crate::commands::build::$name::execute(&sub_matches);
             }
         }};
     }

src/commands/mobile_app/upload.rs src/commands/build/upload.rssrc/commands/mobile_app/upload.rs renamed to src/commands/build/upload.rs

@@ -13,28 +13,27 @@ use zip::{DateTime, ZipWriter};
 use crate::api::{Api, AuthenticatedApi, ChunkUploadCapability, ChunkedFileState, VcsInfo};
 use crate::config::Config;
 use crate::utils::args::ArgExt as _;
+#[cfg(all(target_os = "macos", target_arch = "aarch64"))]
+use crate::utils::build::{handle_asset_catalogs, ipa_to_xcarchive, is_apple_app, is_ipa_file};
+use crate::utils::build::{is_aab_file, is_apk_file, is_zip_file, normalize_directory};
 use crate::utils::chunks::{upload_chunks, Chunk};
 use crate::utils::fs::get_sha1_checksums;
 use crate::utils::fs::TempDir;
 use crate::utils::fs::TempFile;
-#[cfg(all(target_os = "macos", target_arch = "aarch64"))]
-use crate::utils::mobile_app::{
-    handle_asset_catalogs, ipa_to_xcarchive, is_apple_app, is_ipa_file,
-};
-use crate::utils::mobile_app::{is_aab_file, is_apk_file, is_zip_file, normalize_directory};
 use crate::utils::progress::ProgressBar;
 use crate::utils::vcs::{
     self, get_provider_from_remote, get_repo_from_remote, git_repo_remote_url,
 };
 
 pub fn make_command(command: Command) -> Command {
     #[cfg(all(target_os = "macos", target_arch = "aarch64"))]
-    const HELP_TEXT: &str = "The path to the mobile app files to upload. Supported files include Apk, Aab, XCArchive, and IPA.";
+    const HELP_TEXT: &str =
+        "The path to the build to upload. Supported files include Apk, Aab, XCArchive, and IPA.";
     #[cfg(not(all(target_os = "macos", target_arch = "aarch64")))]
     const HELP_TEXT: &str =
-        "The path to the mobile app files to upload. Supported files include Apk, and Aab.";
+        "The path to the build to upload. Supported files include Apk, and Aab.";
     command
-        .about("[EXPERIMENTAL] Upload mobile app files to a project.")
+        .about("[EXPERIMENTAL] Upload builds to a project.")
         .org_arg()
         .project_arg(false)
         .arg(
@@ -149,10 +148,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
     let api = Api::current();
     let authenticated_api = api.authenticated()?;
 
-    debug!(
-        "Starting mobile app upload for {} paths",
-        path_strings.len()
-    );
+    debug!("Starting upload for {} paths", path_strings.len());
 
     let mut normalized_zips = vec![];
     for path_string in path_strings {
@@ -166,7 +162,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
         let byteview = ByteView::open(path)?;
         debug!("Loaded file with {} bytes", byteview.len());
 
-        validate_is_mobile_app(path, &byteview)?;
+        validate_is_supported_build(path, &byteview)?;
 
         let normalized_zip = if path.is_file() {
             debug!("Normalizing file: {}", path.display());
@@ -285,8 +281,8 @@ fn handle_file(path: &Path, byteview: &ByteView) -> Result<TempFile> {
     })
 }
 
-fn validate_is_mobile_app(path: &Path, bytes: &[u8]) -> Result<()> {
-    debug!("Validating mobile app format for: {}", path.display());
+fn validate_is_supported_build(path: &Path, bytes: &[u8]) -> Result<()> {
+    debug!("Validating build format for: {}", path.display());
 
     #[cfg(all(target_os = "macos", target_arch = "aarch64"))]
     if is_apple_app(path) {
@@ -325,7 +321,7 @@ fn validate_is_mobile_app(path: &Path, bytes: &[u8]) -> Result<()> {
     let format_list = "APK, or AAB";
 
     Err(anyhow!(
-        "File is not a recognized mobile app format ({format_list}): {}",
+        "File is not a recognized supported build format ({format_list}): {}",
         path.display()
     ))
 }
@@ -379,7 +375,7 @@ fn upload_file(
     vcs_info: &VcsInfo<'_>,
 ) -> Result<String> {
     const SELF_HOSTED_ERROR_HINT: &str = "If you are using a self-hosted Sentry server, \
-        update to the latest version of Sentry to use the mobile-app upload command.";
+        update to the latest version of Sentry to use the build upload command.";
 
     debug!(
         "Uploading file to organization: {}, project: {}, build_configuration: {}, vcs_info: {:?}",
@@ -392,7 +388,7 @@ fn upload_file(
     let chunk_upload_options = api.get_chunk_upload_options(org)?.ok_or_else(|| {
         anyhow!(
             "The Sentry server lacks chunked uploading support, which \
-                is required for mobile app uploads. {SELF_HOSTED_ERROR_HINT}"
+                is required for build uploads. {SELF_HOSTED_ERROR_HINT}"
         )
     })?;
 
@@ -433,7 +429,7 @@ fn upload_file(
     // n. state=error, artifact_url unset
 
     let result = loop {
-        let response = api.assemble_mobile_app(
+        let response = api.assemble_build(
             org,
             project,
             checksum,
@@ -497,7 +493,7 @@ mod tests {
     #[cfg(all(target_os = "macos", target_arch = "aarch64"))]
     fn test_xcarchive_upload_includes_parsed_assets() -> Result<()> {
         // Test that XCArchive uploads include parsed asset catalogs
-        let xcarchive_path = Path::new("tests/integration/_fixtures/mobile_app/archive.xcarchive");
+        let xcarchive_path = Path::new("tests/integration/_fixtures/build/archive.xcarchive");
 
         // Process the XCArchive directory
         let result = handle_directory(xcarchive_path)?;
@@ -529,7 +525,7 @@ mod tests {
     #[cfg(all(target_os = "macos", target_arch = "aarch64"))]
     fn test_ipa_upload_includes_parsed_assets() -> Result<()> {
         // Test that IPA uploads handle missing asset catalogs gracefully
-        let ipa_path = Path::new("tests/integration/_fixtures/mobile_app/ipa_with_asset.ipa");
+        let ipa_path = Path::new("tests/integration/_fixtures/build/ipa_with_asset.ipa");
         let byteview = ByteView::open(ipa_path)?;
 
         // Process the IPA file - this should work even without asset catalogs

src/commands/mod.rs

@@ -20,6 +20,7 @@ use crate::utils::update::run_sentrycli_update_nagger;
 use crate::utils::value_parsers::auth_token_parser;
 
 mod bash_hook;
+mod build;
 mod dart_symbol_map;
 mod debug_files;
 mod deploys;
@@ -30,7 +31,6 @@ mod info;
 mod issues;
 mod login;
 mod logs;
-mod mobile_app;
 mod monitors;
 mod organizations;
 mod projects;
@@ -52,6 +52,8 @@ mod upload_proguard;
 macro_rules! each_subcommand {
     ($mac:ident) => {
         $mac!(bash_hook);
+        #[cfg(feature = "unstable-build")]
+        $mac!(build);
         $mac!(debug_files);
         $mac!(deploys);
         $mac!(events);