Skip to content

Commit 42740cf

Browse files
romtsnclaude
andcommitted
ref(code-mappings): Simplify result display and extract table helper
Simplify the status match per review feedback and extract the table building logic into a print_results_table function. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent aada310 commit 42740cf

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

src/commands/code_mappings/upload.rs

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use anyhow::{bail, Context as _, Result};
44
use clap::{Arg, ArgMatches, Command};
55
use log::debug;
66

7-
use crate::api::{Api, BulkCodeMapping, BulkCodeMappingsRequest};
7+
use crate::api::{Api, BulkCodeMapping, BulkCodeMappingResult, BulkCodeMappingsRequest};
88
use crate::config::Config;
99
use crate::utils::formatting::Table;
1010
use crate::utils::vcs;
@@ -86,31 +86,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
8686
.authenticated()?
8787
.bulk_upload_code_mappings(&org, &request)?;
8888

89-
// Display results
90-
let mut table = Table::new();
91-
table
92-
.title_row()
93-
.add("Stack Root")
94-
.add("Source Root")
95-
.add("Status");
96-
97-
for result in &response.mappings {
98-
let status = match result.status.as_str() {
99-
"error" => match &result.detail {
100-
Some(detail) => format!("error: {detail}"),
101-
None => "error".to_owned(),
102-
},
103-
s => s.to_owned(),
104-
};
105-
table
106-
.add_row()
107-
.add(&result.stack_root)
108-
.add(&result.source_root)
109-
.add(&status);
110-
}
111-
112-
table.print();
113-
println!();
89+
print_results_table(response.mappings);
11490
println!(
11591
"Created: {}, Updated: {}, Errors: {}",
11692
response.created, response.updated, response.errors
@@ -398,3 +374,27 @@ mod tests {
398374
assert_eq!(branch, "develop");
399375
}
400376
}
377+
378+
fn print_results_table(mappings: Vec<BulkCodeMappingResult>) {
379+
let mut table = Table::new();
380+
table
381+
.title_row()
382+
.add("Stack Root")
383+
.add("Source Root")
384+
.add("Status");
385+
386+
for result in mappings {
387+
let status = match result.detail {
388+
Some(detail) if result.status == "error" => format!("error: {detail}"),
389+
_ => result.status,
390+
};
391+
table
392+
.add_row()
393+
.add(&result.stack_root)
394+
.add(&result.source_root)
395+
.add(&status);
396+
}
397+
398+
table.print();
399+
println!();
400+
}

0 commit comments

Comments
 (0)