Address remaining review feedback from szokeasaurusrex

- Remove explicit type annotation from get_one() call
- Move test into proper mod tests block with #[cfg(test)]

Addresses the final review comments on the PR.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: runningcode

src/commands/build/upload.rs

@@ -197,7 +197,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
     let base_repo_name = matches.get_one("base_repo_name").map(String::as_str);
     let base_sha = matches.get_one("base_sha").map(String::as_str);
     let pr_number = matches
-        .get_one::<u32>("pr_number")
+        .get_one("pr_number")
         .copied()
         .or_else(get_github_pr_number);
 

src/utils/vcs.rs

@@ -1301,19 +1301,24 @@ fn test_git_repo_head_ref() {
     );
 }
 
-#[test]
-fn test_get_github_pr_number() {
-    std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
-    std::env::set_var("GITHUB_REF", "refs/pull/123/merge");
-    let pr_number = get_github_pr_number();
-    assert_eq!(pr_number, Some(123));
-    std::env::set_var("GITHUB_EVENT_NAME", "push");
-    let pr_number = get_github_pr_number();
-    assert_eq!(pr_number, None);
-    std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
-    std::env::set_var("GITHUB_REF", "refs/heads/main");
-    let pr_number = get_github_pr_number();
-    assert_eq!(pr_number, None);
-    std::env::remove_var("GITHUB_EVENT_NAME");
-    std::env::remove_var("GITHUB_REF");
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_get_github_pr_number() {
+        std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
+        std::env::set_var("GITHUB_REF", "refs/pull/123/merge");
+        let pr_number = get_github_pr_number();
+        assert_eq!(pr_number, Some(123));
+        std::env::set_var("GITHUB_EVENT_NAME", "push");
+        let pr_number = get_github_pr_number();
+        assert_eq!(pr_number, None);
+        std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
+        std::env::set_var("GITHUB_REF", "refs/heads/main");
+        let pr_number = get_github_pr_number();
+        assert_eq!(pr_number, None);
+        std::env::remove_var("GITHUB_EVENT_NAME");
+        std::env::remove_var("GITHUB_REF");
+    }
 }