fix(proguard): Deprecate no-op --platform option (#2863)

### Description
This option has been a no-op for some time; it likely should have been
deprecated when we stopped reading it.

### Issues
- Fixes #2850
- Fixes CLI-192

Author: szokeasaurusrex

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Deprecations
+
+- Deprecated the `upload-proguard` subcommand's `--platform` flag ([#2863](https://github.com/getsentry/sentry-cli/pull/2863)). This flag appears to have been a no-op for some time, so we will remove it in the next major.
+
 ## 2.57.0
 
 ### New Features

src/commands/upload_proguard.rs

@@ -85,12 +85,13 @@ pub fn make_command(command: Command) -> Command {
         )
         .arg(
             Arg::new("platform")
+                .hide(true)
                 .long("platform")
                 .value_name("PLATFORM")
                 .requires("app_id")
                 .help(
-                    "Optionally defines the platform for the app association. \
-                     [defaults to 'android']",
+                    "[DEPRECATED] This flag is a no-op, scheduled \
+                    for removal in Sentry CLI 3.0.0.",
                 ),
         )
         .arg(
@@ -145,6 +146,14 @@ pub fn make_command(command: Command) -> Command {
 }
 
 pub fn execute(matches: &ArgMatches) -> Result<()> {
+    if matches.get_one::<String>("platform").is_some() {
+        log::warn!(
+            "[DEPRECATION NOTICE] The --platform argument is deprecated, \
+            and is scheduled for removal in Sentry CLI 3.0.0. \
+            The argument is a no-op."
+        );
+    }
+
     let paths: Vec<_> = match matches.get_many::<String>("paths") {
         Some(paths) => paths.collect(),
         None => {

tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd

@@ -16,8 +16,6 @@ Options:
       --auth-token <AUTH_TOKEN>  Use the given Sentry auth token.
       --log-level <LOG_LEVEL>    Set the log output verbosity. [possible values: trace, debug, info,
                                  warn, error]
-      --platform <PLATFORM>      Optionally defines the platform for the app association. [defaults
-                                 to 'android']
       --quiet                    Do not print any output while preserving correct exit code. This
                                  flag is currently implemented only for selected subcommands.
                                  [aliases: --silent]