Skip to content

Commit 7a3f4aa

Browse files
chore(proguard): Deprecate release association flags
Proguard Release Association is a thing of the past. Here, we deprecate the flags for setting the relationship.
1 parent 8ad27a9 commit 7a3f4aa

1 file changed

Lines changed: 30 additions & 7 deletions

File tree

src/commands/upload_proguard.rs

Lines changed: 30 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,36 +35,52 @@ pub fn make_command(command: Command) -> Command {
3535
)
3636
.arg(
3737
Arg::new("version")
38+
.hide(true)
3839
.long("version")
3940
.value_name("VERSION")
4041
.requires("app_id")
4142
.help(
42-
"Optionally associate the mapping files with a human \
43-
readable version.{n}This helps you understand which \
44-
ProGuard files go with which version of your app.",
43+
"[DEPRECATED] Optionally associate the mapping files \
44+
with a human readable version.{n}This helps you \
45+
understand which ProGuard files go with which version \
46+
of your app.\n\
47+
Sentry SaaS and self-hosted version 25.9.0 and later no \
48+
longer display this association, as it has no effect on \
49+
symbol resolution. This flag is scheduled for removal in \
50+
Sentry CLI 3.0.0.",
4551
),
4652
)
4753
.arg(
4854
Arg::new("version_code")
55+
.hide(true)
4956
.long("version-code")
5057
.value_name("VERSION_CODE")
5158
.requires("app_id")
5259
.requires("version")
5360
.help(
54-
"Optionally associate the mapping files with a version \
61+
"[DEPRECATED] Optionally associate the mapping files with a version \
5562
code.{n}This helps you understand which ProGuard files \
56-
go with which version of your app.",
63+
go with which version of your app.\n\
64+
Sentry SaaS and self-hosted version 25.9.0 and later no \
65+
longer display this association, as it has no effect on \
66+
symbol resolution. This flag is scheduled for removal in \
67+
Sentry CLI 3.0.0.",
5768
),
5869
)
5970
.arg(
6071
Arg::new("app_id")
72+
.hide(true)
6173
.long("app-id")
6274
.value_name("APP_ID")
6375
.requires("version")
6476
.help(
65-
"Optionally associate the mapping files with an application \
77+
"[DEPRECATED] Optionally associate the mapping files with an application \
6678
ID.{n}If you have multiple apps in one sentry project, you can \
67-
then easily tell them apart.",
79+
then easily tell them apart.\n\
80+
Sentry SaaS and self-hosted version 25.9.0 and later no \
81+
longer display this association, as it has no effect on \
82+
symbol resolution. This flag is scheduled for removal in \
83+
Sentry CLI 3.0.0.",
6884
),
6985
)
7086
.arg(
@@ -267,6 +283,13 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
267283

268284
// if values are given associate
269285
if let Some(app_id) = matches.get_one::<String>("app_id") {
286+
log::warn!(
287+
"[DEPRECATION NOTICE] The --app-id, --version, and --version-code flags are deprecated. \
288+
and scheduled for removal in Sentry CLI 3.0.0. \
289+
These values have no effect on symbol resolution, and are no longer displayed anywhere \
290+
in the Sentry UI (neither in SaaS nor in self-hosted versions 25.9.0 and later)."
291+
);
292+
270293
#[expect(clippy::unwrap_used, reason = "legacy code")]
271294
let version = matches.get_one::<String>("version").unwrap().to_owned();
272295
let build: Option<String> = matches.get_one::<String>("version_code").cloned();

0 commit comments

Comments
 (0)