Skip to content

Commit 868934a

Browse files
runningcodeclaude
andcommitted
Update integration tests for help text changes
- Split long help string across multiple lines using backslashes - Clarify that PR number detection only works in pull_request-triggered workflows 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent c1c8e00 commit 868934a

File tree

2 files changed

+20
-22
lines changed

2 files changed

+20
-22
lines changed

src/commands/build/upload.rs

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ pub fn make_command(command: Command) -> Command {
8686
Arg::new("pr_number")
8787
.long("pr-number")
8888
.value_parser(clap::value_parser!(u32))
89-
.help("The pull request number to use for the upload. If not provided and running in a GitHub Actions environment, the PR number will be automatically detected from GitHub Actions environment variables.")
89+
.help("The pull request number to use for the upload. If not provided and running \
90+
in a pull_request-triggered GitHub Actions workflow, the PR number will be automatically \
91+
detected from GitHub Actions environment variables.")
9092
)
9193
.arg(
9294
Arg::new("build_configuration")
@@ -601,25 +603,4 @@ mod tests {
601603
);
602604
Ok(())
603605
}
604-
605-
#[test]
606-
fn test_get_github_pr_number() {
607-
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
608-
std::env::set_var("GITHUB_REF", "refs/pull/123/merge");
609-
610-
let pr_number = get_github_pr_number();
611-
assert_eq!(pr_number, Some(123));
612-
613-
std::env::set_var("GITHUB_EVENT_NAME", "push");
614-
let pr_number = get_github_pr_number();
615-
assert_eq!(pr_number, None);
616-
617-
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
618-
std::env::set_var("GITHUB_REF", "refs/heads/main");
619-
let pr_number = get_github_pr_number();
620-
assert_eq!(pr_number, None);
621-
622-
std::env::remove_var("GITHUB_EVENT_NAME");
623-
std::env::remove_var("GITHUB_REF");
624-
}
625606
}

src/utils/vcs.rs

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1266,3 +1266,20 @@ fn test_git_repo_head_ref() {
12661266
"HEAD is detached - no branch reference available"
12671267
);
12681268
}
1269+
1270+
#[test]
1271+
fn test_get_github_pr_number() {
1272+
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
1273+
std::env::set_var("GITHUB_REF", "refs/pull/123/merge");
1274+
let pr_number = get_github_pr_number();
1275+
assert_eq!(pr_number, Some(123));
1276+
std::env::set_var("GITHUB_EVENT_NAME", "push");
1277+
let pr_number = get_github_pr_number();
1278+
assert_eq!(pr_number, None);
1279+
std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
1280+
std::env::set_var("GITHUB_REF", "refs/heads/main");
1281+
let pr_number = get_github_pr_number();
1282+
assert_eq!(pr_number, None);
1283+
std::env::remove_var("GITHUB_EVENT_NAME");
1284+
std::env::remove_var("GITHUB_REF");
1285+
}

0 commit comments

Comments
 (0)