chore(clippy): Enable implicit-clone lint

Enable `implicit-clone` lint and disable the `string-to-string` lint, as `implicit-clone` now also lints `to_string` calls, making `string-to-string` redundant. See https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#enhancements

Author: szokeasaurusrex

Cargo.toml

@@ -99,8 +99,8 @@ with_crash_reporting = []
 allow-attributes = "warn"
 dbg-macro = "warn"
 elidable-lifetime-names = "warn"
+implicit-clone = "warn"
 str-to-string = "warn"
-string-to-string = "warn"
 tests-outside-test-module = "warn"
 unnecessary-wraps = "warn"
 uninlined-format-args = "warn"

src/commands/debug_files/bundle_jvm.rs

@@ -88,7 +88,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
         ))?;
     }
 
-    let sources = ReleaseFileSearch::new(path.to_path_buf()).collect_files()?;
+    let sources = ReleaseFileSearch::new(path.clone()).collect_files()?;
     let files = sources
         .iter()
         .map(|source| {

src/commands/debug_files/find.rs

@@ -324,7 +324,7 @@ where
 {
     ids.filter_map(|id| {
         if remaining.contains(&id) {
-            return Some((id.to_owned(), t));
+            return Some((id, t));
         }
         None
     })

src/commands/upload_proguard.rs

@@ -329,7 +329,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                 &org,
                 &project,
                 &AssociateProguard {
-                    release_name: release_name.to_owned(),
+                    release_name: release_name.clone(),
                     proguard_uuid: uuid.to_string(),
                 },
             )?;

src/utils/xcode.rs

@@ -93,7 +93,7 @@ fn get_xcode_project_info(path: &Path) -> Result<Option<XcodeProjectInfo>> {
     for entry in (fs::read_dir(path)?).flatten() {
         if let Some(filename) = entry.file_name().to_str() {
             if filename.ends_with(".xcodeproj") {
-                projects.push(entry.path().to_path_buf());
+                projects.push(entry.path().clone());
             }
         }
     }