Remove unstable-mobile-app feature gating

Author: rbro112

.github/workflows/ci.yml

@@ -18,14 +18,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-24.04, macos-14, windows-2022]
-        feature-args: ['', '-Funstable-mobile-app']
-        include:
-          - feature-args: ''
-            feature-suffix: ''
-          - feature-args: '-Funstable-mobile-app'
-            feature-suffix: ', mobile-app'
-
-    name: Lint (${{ matrix.os }}${{ matrix.feature-suffix }})
+
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
@@ -39,7 +32,7 @@ jobs:
         run: cargo fmt --all -- --check
 
       - name: Run Clippy
-        run: cargo clippy --workspace --tests ${{ matrix.feature-args }}
+        run: cargo clippy --workspace --tests
 
   lint:
     needs: lint-each-os
@@ -58,14 +51,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-24.04, macos-14, windows-2022]
-        feature-args: ['', '-Funstable-mobile-app']
-        include:
-          - feature-args: ''
-            feature-suffix: ''
-          - feature-args: '-Funstable-mobile-app'
-            feature-suffix: ', mobile-app'
-
-    name: Test (${{ matrix.os }}${{ matrix.feature-suffix }})
+
     runs-on: ${{ matrix.os }}
 
     steps:
@@ -76,7 +62,7 @@ jobs:
           key: ${{ github.job }}
 
       - name: Run Cargo Tests
-        run: cargo test --all ${{ matrix.feature-args }}
+        run: cargo test --all
 
   test_node:
     strategy:

.vscode/settings.json

@@ -1,4 +0,0 @@
-{
-    "rust-analyzer.cargo.features": ["unstable-mobile-app"],
-    "rust-analyzer.cargo.noDefaultFeatures": false
-}

Cargo.toml

@@ -94,10 +94,6 @@ default = []
 managed = []
 with_crash_reporting = []
 
-# Feature flag for the mobile-app command, as it is still under development.
-# CI tests run against this flag, but we don't include it in release builds.
-unstable-mobile-app = ["apple-catalog-parsing"]
-
 [workspace.lints.clippy]
 allow-attributes = "warn"
 unnecessary-wraps = "warn"

src/api/data_types/chunking/mobile_app.rs

@@ -1,4 +1,3 @@
-#![cfg(feature = "unstable-mobile-app")]
 use serde::{Deserialize, Serialize};
 use sha1_smol::Digest;
 

src/api/data_types/chunking/mod.rs

@@ -14,6 +14,5 @@ pub use self::compression::ChunkCompression;
 pub use self::dif::{AssembleDifsRequest, AssembleDifsResponse, ChunkedDifRequest};
 pub use self::file_state::ChunkedFileState;
 pub use self::hash_algorithm::ChunkHashAlgorithm;
-#[cfg(feature = "unstable-mobile-app")]
 pub use self::mobile_app::{AssembleMobileAppResponse, ChunkedMobileAppRequest};
 pub use self::upload::{ChunkServerOptions, ChunkUploadCapability};

src/api/mod.rs

@@ -1018,7 +1018,6 @@ impl<'a> AuthenticatedApi<'a> {
             .convert_rnf(ApiErrorKind::ReleaseNotFound)
     }
 
-    #[cfg(feature = "unstable-mobile-app")]
     pub fn assemble_mobile_app(
         &self,
         org: &str,

src/commands/mobile_app/mod.rs

@@ -1,5 +1,3 @@
-#![cfg(feature = "unstable-mobile-app")]
-
 use anyhow::Result;
 use clap::{ArgMatches, Command};
 

src/commands/mod.rs

@@ -31,7 +31,6 @@ macro_rules! each_subcommand {
         $mac!(info);
         $mac!(issues);
         $mac!(login);
-        #[cfg(feature = "unstable-mobile-app")]
         $mac!(mobile_app);
         $mac!(monitors);
         $mac!(organizations);

src/utils/mobile_app/mod.rs

@@ -1,5 +1,3 @@
-#![cfg(feature = "unstable-mobile-app")]
-
 #[cfg(target_os = "macos")]
 mod apple;
 mod validation;

tests/integration/mobile_app/mod.rs

@@ -1,5 +1,3 @@
-#![cfg(feature = "unstable-mobile-app")]
-
 use crate::integration::TestManager;
 
 mod upload;