Skip to content

Commit 95eabf6

Browse files
chore(sourcemaps): Add deprecation notice for non-chunked uploads (#2837)
### Description Support for non-chunked uploads debug file uploads will be removed in the next major release. Sentry self-hosted versions [since 10.0.0](getsentry/sentry@209e42f), which was released six years ago, support chunked uploads for debug file uploads ### Issues - Resolves #2835 - Resolves CLI-184 <!-- #### Reminders - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
1 parent a38ecaa commit 95eabf6

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/utils/file_upload.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -377,10 +377,12 @@ impl<'a> FileUpload<'a> {
377377
}
378378

379379
log::warn!(
380-
"Your Sentry server does not support chunked uploads. \
381-
We are falling back to a legacy upload method, which \
382-
has fewer features and is less reliable. Please consider \
383-
upgrading your Sentry server or switching to our SaaS offering."
380+
"[DEPRECATION NOTICE] Your Sentry server does not support chunked uploads for \
381+
sourcemaps/release files. Falling back to deprecated upload method, which has fewer \
382+
features and is less reliable. Support for this deprecated upload method will be \
383+
removed in Sentry CLI 3.0.0. Please upgrade your Sentry server, or if you cannot \
384+
upgrade, pin your Sentry CLI version to 2.x, so you don't get upgraded to 3.x when \
385+
it is released."
384386
);
385387

386388
// Do not permit uploads of more than 20k files if the server does not
@@ -411,6 +413,7 @@ impl<'a> FileUpload<'a> {
411413
)
412414
})?;
413415

416+
#[expect(deprecated, reason = "fallback to legacy upload")]
414417
upload_files_parallel(legacy_context, &self.files, concurrency)
415418
}
416419

@@ -419,6 +422,7 @@ impl<'a> FileUpload<'a> {
419422
}
420423
}
421424

425+
#[deprecated = "this non-chunked upload mechanism is deprecated in favor of upload_files_chunked"]
422426
fn upload_files_parallel(
423427
context: &LegacyUploadContext,
424428
files: &SourceFiles,

0 commit comments

Comments
 (0)