Skip to content

Commit acf91a5

Browse files
committed
revert prior changes
1 parent 8b900ad commit acf91a5

1 file changed

Lines changed: 5 additions & 80 deletions

File tree

src/utils/vcs.rs

Lines changed: 5 additions & 80 deletions
Original file line numberDiff line numberDiff line change
@@ -472,21 +472,6 @@ fn find_matching_submodule(
472472
Ok(None)
473473
}
474474

475-
/// Helper function to determine which SHA to use for the API
476-
/// Returns the original partial SHA if it looks like a partial SHA,
477-
/// otherwise returns the resolved SHA
478-
fn get_api_sha(original: &str, resolved: &str) -> String {
479-
let is_original_partial = original.len() >= 4
480-
&& original.len() < 40
481-
&& original.chars().all(|c| c.is_ascii_hexdigit());
482-
483-
if is_original_partial {
484-
original.to_owned()
485-
} else {
486-
resolved.to_owned()
487-
}
488-
}
489-
490475
fn find_matching_revs(
491476
spec: &CommitSpec,
492477
repos: &[Repo],
@@ -504,23 +489,21 @@ fn find_matching_revs(
504489
)
505490
}
506491

507-
let rev = if let Some(resolved_sha) = find_matching_rev(
492+
let rev = if let Some(rev) = find_matching_rev(
508493
spec.reference(),
509494
spec,
510495
repos,
511496
disable_discovery,
512497
remote_name.clone(),
513498
)? {
514-
get_api_sha(&spec.rev, &resolved_sha)
499+
rev
515500
} else {
516501
return Err(error(spec.reference(), &spec.repo));
517502
};
518503

519504
let prev_rev = if let Some(rev) = spec.prev_reference() {
520-
if let Some(resolved_sha) =
521-
find_matching_rev(rev, spec, repos, disable_discovery, remote_name)?
522-
{
523-
Some(get_api_sha(spec.prev_rev.as_ref().unwrap(), &resolved_sha))
505+
if let Some(rv) = find_matching_rev(rev, spec, repos, disable_discovery, remote_name)? {
506+
Some(rv)
524507
} else {
525508
return Err(error(rev, &spec.repo));
526509
}
@@ -1368,62 +1351,4 @@ mod tests {
13681351
std::env::remove_var("GITHUB_EVENT_NAME");
13691352
std::env::remove_var("GITHUB_REF");
13701353
}
1371-
1372-
#[test]
1373-
fn test_get_api_sha_partial_sha() {
1374-
let original = "4eba";
1375-
let resolved = "4eba000000000000000000000000000000000000";
1376-
assert_eq!(get_api_sha(original, resolved), "4eba");
1377-
1378-
let original = "4ebad56";
1379-
let resolved = "4ebad56000000000000000000000000000000000";
1380-
assert_eq!(get_api_sha(original, resolved), "4ebad56");
1381-
1382-
let original = "abc123def";
1383-
let resolved = "abc123def0000000000000000000000000000000";
1384-
assert_eq!(get_api_sha(original, resolved), "abc123def");
1385-
1386-
let original = "4ebad56f915d32a0b8c8c8c8c8c8c8c8c8c8c8c";
1387-
let resolved = "4ebad56f915d32a0b8c8c8c8c8c8c8c8c8c8c8c0";
1388-
assert_eq!(
1389-
get_api_sha(original, resolved),
1390-
"4ebad56f915d32a0b8c8c8c8c8c8c8c8c8c8c8c"
1391-
);
1392-
}
1393-
1394-
#[test]
1395-
fn test_get_api_sha_full_sha() {
1396-
let original = "4ebad56f915d32a0b8c8c8c8c8c8c8c8c8c8c8c8c8";
1397-
let resolved = "4ebad56f915d32a0b8c8c8c8c8c8c8c8c8c8c8c8c8";
1398-
assert_eq!(get_api_sha(original, resolved), resolved);
1399-
}
1400-
1401-
#[test]
1402-
fn test_get_api_sha_too_short() {
1403-
let original = "4eb";
1404-
let resolved = "4eb0000000000000000000000000000000000000";
1405-
assert_eq!(get_api_sha(original, resolved), resolved);
1406-
}
1407-
1408-
#[test]
1409-
fn test_get_api_sha_symbolic() {
1410-
let original = "HEAD";
1411-
let resolved = "4ebad56f915d32a0b8c8c8c8c8c8c8c8c8c8c8c8c8";
1412-
assert_eq!(get_api_sha(original, resolved), resolved);
1413-
1414-
let original = "main";
1415-
let resolved = "4ebad56f915d32a0b8c8c8c8c8c8c8c8c8c8c8c8c8";
1416-
assert_eq!(get_api_sha(original, resolved), resolved);
1417-
}
1418-
1419-
#[test]
1420-
fn test_get_api_sha_mixed_case_hex() {
1421-
let original = "4EbAd56";
1422-
let resolved = "4EbAd56000000000000000000000000000000000";
1423-
assert_eq!(get_api_sha(original, resolved), "4EbAd56");
1424-
1425-
let original = "ABCDEF1";
1426-
let resolved = "ABCDEF1000000000000000000000000000000000";
1427-
assert_eq!(get_api_sha(original, resolved), "ABCDEF1");
1428-
}
1429-
}
1354+
}

0 commit comments

Comments
 (0)