ref(clippy): Enable tests-outside-test-module lint

Enable the [`tests-outside-test-module`](https://rust-lang.github.io/rust-clippy/master/index.html#tests_outside_test_module) Clippy lint, and fix violations.

This lint will enforce the convention that `#[test]` items must be placed within a `#[cfg(test)]` module.

Author: szokeasaurusrex

Cargo.toml

@@ -98,6 +98,7 @@ with_crash_reporting = []
 allow-attributes = "warn"
 str-to-string = "warn"
 string-to-string = "warn"
+tests-outside-test-module = "warn"
 unnecessary-wraps = "warn"
 uninlined-format-args = "warn"
 unused-trait-names = "warn"

src/commands/mod.rs

@@ -392,7 +392,12 @@ pub fn main() -> ! {
     process::exit(exit_code);
 }
 
-#[test]
-fn verify_app() {
-    app().debug_assert();
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn verify_app() {
+        app().debug_assert();
+    }
 }

src/commands/sourcemaps/explain.rs

@@ -467,52 +467,57 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
     Ok(())
 }
 
-#[test]
-fn test_resolve_sourcemap_url() {
-    // Tests coming from `tests/sentry/utils/test_urls.py` in `getsentry/sentry`
-    let cases = vec![
-        ("http://example.com/foo", "bar", "http://example.com/bar"),
-        ("http://example.com/foo", "/bar", "http://example.com/bar"),
-        ("https://example.com/foo", "/bar", "https://example.com/bar"),
-        (
-            "http://example.com/foo/baz",
-            "bar",
-            "http://example.com/foo/bar",
-        ),
-        (
-            "http://example.com/foo/baz",
-            "/bar",
-            "http://example.com/bar",
-        ),
-        ("aps://example.com/foo", "/bar", "aps://example.com/bar"),
-        (
-            "apsunknown://example.com/foo",
-            "/bar",
-            "apsunknown://example.com/bar",
-        ),
-        (
-            "apsunknown://example.com/foo",
-            "//aha/uhu",
-            "apsunknown://aha/uhu",
-        ),
-    ];
-
-    for (base, to_join, expected) in cases {
-        assert_eq!(resolve_sourcemap_url(base, to_join).unwrap(), expected);
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_resolve_sourcemap_url() {
+        // Tests coming from `tests/sentry/utils/test_urls.py` in `getsentry/sentry`
+        let cases = vec![
+            ("http://example.com/foo", "bar", "http://example.com/bar"),
+            ("http://example.com/foo", "/bar", "http://example.com/bar"),
+            ("https://example.com/foo", "/bar", "https://example.com/bar"),
+            (
+                "http://example.com/foo/baz",
+                "bar",
+                "http://example.com/foo/bar",
+            ),
+            (
+                "http://example.com/foo/baz",
+                "/bar",
+                "http://example.com/bar",
+            ),
+            ("aps://example.com/foo", "/bar", "aps://example.com/bar"),
+            (
+                "apsunknown://example.com/foo",
+                "/bar",
+                "apsunknown://example.com/bar",
+            ),
+            (
+                "apsunknown://example.com/foo",
+                "//aha/uhu",
+                "apsunknown://aha/uhu",
+            ),
+        ];
+
+        for (base, to_join, expected) in cases {
+            assert_eq!(resolve_sourcemap_url(base, to_join).unwrap(), expected);
+        }
     }
-}
 
-#[test]
-fn test_unify_artifact_url() {
-    let cases = vec![
-        (
-            "http://localhost:5000/dist/bundle.min.js",
-            "~/dist/bundle.min.js",
-        ),
-        ("/dist/bundle.js.map", "~/dist/bundle.js.map"),
-    ];
-
-    for (path, expected) in cases {
-        assert_eq!(unify_artifact_url(path).unwrap(), expected);
+    #[test]
+    fn test_unify_artifact_url() {
+        let cases = vec![
+            (
+                "http://localhost:5000/dist/bundle.min.js",
+                "~/dist/bundle.min.js",
+            ),
+            ("/dist/bundle.js.map", "~/dist/bundle.js.map"),
+        ];
+
+        for (path, expected) in cases {
+            assert_eq!(unify_artifact_url(path).unwrap(), expected);
+        }
     }
 }

src/utils/http.rs

@@ -72,40 +72,45 @@ pub fn is_absolute_url(url: &str) -> bool {
     url.starts_with("http://") || url.starts_with("https://")
 }
 
-#[test]
-fn test_parse_link_header() {
-    let rv = parse_link_header("<https://sentry.io/api/0/organizations/sentry/releases/?&cursor=100:-1:1>; rel=\"previous\"; results=\"false\"; cursor=\"100:-1:1\", <https://sentry.io/api/0/organizations/sentry/releases/?&cursor=100:1:0>; rel=\"next\"; results=\"true\"; cursor=\"100:1:0\"");
-    assert_eq!(rv.len(), 2);
-
-    let a = &rv[0];
-    let b = &rv[1];
-
-    assert_eq!(
-        a.get("_link").unwrap(),
-        &"https://sentry.io/api/0/organizations/sentry/releases/?&cursor=100:-1:1"
-    );
-    assert_eq!(a.get("cursor").unwrap(), &"100:-1:1");
-    assert_eq!(a.get("rel").unwrap(), &"previous");
-    assert_eq!(a.get("results").unwrap(), &"false");
-
-    assert_eq!(
-        b.get("_link").unwrap(),
-        &"https://sentry.io/api/0/organizations/sentry/releases/?&cursor=100:1:0"
-    );
-    assert_eq!(b.get("cursor").unwrap(), &"100:1:0");
-    assert_eq!(b.get("rel").unwrap(), &"next");
-    assert_eq!(b.get("results").unwrap(), &"true");
-}
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_parse_link_header() {
+        let rv = parse_link_header("<https://sentry.io/api/0/organizations/sentry/releases/?&cursor=100:-1:1>; rel=\"previous\"; results=\"false\"; cursor=\"100:-1:1\", <https://sentry.io/api/0/organizations/sentry/releases/?&cursor=100:1:0>; rel=\"next\"; results=\"true\"; cursor=\"100:1:0\"");
+        assert_eq!(rv.len(), 2);
+
+        let a = &rv[0];
+        let b = &rv[1];
+
+        assert_eq!(
+            a.get("_link").unwrap(),
+            &"https://sentry.io/api/0/organizations/sentry/releases/?&cursor=100:-1:1"
+        );
+        assert_eq!(a.get("cursor").unwrap(), &"100:-1:1");
+        assert_eq!(a.get("rel").unwrap(), &"previous");
+        assert_eq!(a.get("results").unwrap(), &"false");
 
-#[test]
-fn test_is_absolute_url() {
-    assert!(is_absolute_url("https://sentry.io"));
-    assert!(is_absolute_url("http://sentry.io"));
-    assert!(is_absolute_url("https://sentry.io/path"));
-    assert!(is_absolute_url("http://sentry.io/path"));
-    assert!(is_absolute_url("http://sentry.io/path?query=foo"));
-    assert!(is_absolute_url("https://sentry.io/path?query=foo"));
-
-    assert!(!is_absolute_url("/path"));
-    assert!(!is_absolute_url("/path?query=foo"));
+        assert_eq!(
+            b.get("_link").unwrap(),
+            &"https://sentry.io/api/0/organizations/sentry/releases/?&cursor=100:1:0"
+        );
+        assert_eq!(b.get("cursor").unwrap(), &"100:1:0");
+        assert_eq!(b.get("rel").unwrap(), &"next");
+        assert_eq!(b.get("results").unwrap(), &"true");
+    }
+
+    #[test]
+    fn test_is_absolute_url() {
+        assert!(is_absolute_url("https://sentry.io"));
+        assert!(is_absolute_url("http://sentry.io"));
+        assert!(is_absolute_url("https://sentry.io/path"));
+        assert!(is_absolute_url("http://sentry.io/path"));
+        assert!(is_absolute_url("http://sentry.io/path?query=foo"));
+        assert!(is_absolute_url("https://sentry.io/path?query=foo"));
+
+        assert!(!is_absolute_url("/path"));
+        assert!(!is_absolute_url("/path?query=foo"));
+    }
 }