Skip to content

Commit c1c8e00

Browse files
runningcodeclaude
andcommitted
Address review feedback: add debug logging and simplify PR parsing
- Add debug logging for failure points in get_github_pr_number - Remove explicit type annotation from parse() call - Remove redundant starts_with check since strip_prefix handles it 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 6e67ff5 commit c1c8e00

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/utils/vcs.rs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,13 +255,18 @@ pub fn get_github_pr_number() -> Option<u32> {
255255
let github_ref = std::env::var("GITHUB_REF").ok()?;
256256
let event_name = std::env::var("GITHUB_EVENT_NAME").ok()?;
257257

258-
if event_name != "pull_request" || !github_ref.starts_with("refs/pull/") {
258+
if event_name != "pull_request" {
259+
debug!("Not running in pull_request event, got: {}", event_name);
259260
return None;
260261
}
261262

262-
let pr_number_str = github_ref.strip_prefix("refs/pull/")?.split('/').next()?;
263+
let pr_number_str = github_ref.strip_prefix("refs/pull/")?;
264+
debug!("Extracted PR reference: {}", pr_number_str);
265+
266+
let pr_number_str = pr_number_str.split('/').next()?;
267+
debug!("Parsing PR number from: {}", pr_number_str);
263268

264-
let pr_number = pr_number_str.parse::<u32>().ok()?;
269+
let pr_number = pr_number_str.parse().ok()?;
265270
debug!("Auto-detected PR number from GitHub Actions: {}", pr_number);
266271
Some(pr_number)
267272
}

0 commit comments

Comments
 (0)