feat(mobile-app): Make missing path not panic (#2583)

Updates the mobile-app upload command to no longer panic upon a missing
path argument, rather log an error and exit gracefully. Adds a test to
validate this behavior.

Author: rbro112

src/commands/mobile_app/upload.rs

@@ -34,7 +34,8 @@ pub fn make_command(command: Command) -> Command {
                 .value_name("PATH")
                 .help("The path to the mobile app files to upload. Supported files include Apk, Aab or XCArchive.")
                 .num_args(1..)
-                .action(ArgAction::Append),
+                .action(ArgAction::Append)
+                .required(true),
         )
         .arg(
             Arg::new("sha")
@@ -49,9 +50,12 @@ pub fn make_command(command: Command) -> Command {
 }
 
 pub fn execute(matches: &ArgMatches) -> Result<()> {
-    let path_strings = matches
-        .get_many::<String>("paths")
-        .expect("paths argument is required");
+    let path_strings: Vec<_> = match matches.get_many::<String>("paths") {
+        Some(paths) => paths.collect(),
+        None => {
+            return Err(anyhow!("clap error: paths argument is required"));
+        }
+    };
 
     let sha = matches
         .get_one("sha")
@@ -301,14 +305,12 @@ fn upload_file(
         build_configuration.unwrap_or("unknown")
     );
 
-    let chunk_upload_options = api
-        .get_chunk_upload_options(org)?
-        .ok_or_else(|| {
-            anyhow!(
-                "The Sentry server lacks chunked uploading support, which \
+    let chunk_upload_options = api.get_chunk_upload_options(org)?.ok_or_else(|| {
+        anyhow!(
+            "The Sentry server lacks chunked uploading support, which \
                 is required for mobile app uploads. {SELF_HOSTED_ERROR_HINT}"
-            )
-        })?;
+        )
+    })?;
 
     if !chunk_upload_options.supports(ChunkUploadCapability::PreprodArtifacts) {
         bail!(

tests/integration/_cases/mobile_app/mobile_app-upload-help.trycmd

@@ -3,10 +3,10 @@ $ sentry-cli mobile-app upload --help
 ? success
 [EXPERIMENTAL] Upload mobile app files to a project.
 
-Usage: sentry-cli[EXE] mobile-app upload [OPTIONS] [PATH]...
+Usage: sentry-cli[EXE] mobile-app upload [OPTIONS] <PATH>...
 
 Arguments:
-  [PATH]...  The path to the mobile app files to upload. Supported files include Apk, Aab or
+  <PATH>...  The path to the mobile app files to upload. Supported files include Apk, Aab or
              XCArchive.
 
 Options:

tests/integration/_cases/mobile_app/mobile_app-upload-no-path.trycmd

@@ -0,0 +1,11 @@
+```
+$ sentry-cli mobile-app upload
+? failed
+error: the following required arguments were not provided:
+  <PATH>...
+
+Usage: sentry-cli[EXE] mobile-app upload <PATH>...
+
+For more information, try '--help'.
+
+```

tests/integration/mobile_app/upload.rs

@@ -14,6 +14,11 @@ fn command_mobile_app_upload_no_token() {
     TestManager::new().register_trycmd_test("mobile_app/mobile_app-upload-apk-no-token.trycmd");
 }
 
+#[test]
+fn command_mobile_app_upload_no_path() {
+    TestManager::new().register_trycmd_test("mobile_app/mobile_app-upload-no-path.trycmd");
+}
+
 #[test]
 fn command_mobile_app_upload_invalid_aab() {
     TestManager::new()