Address PR feedback: improve get_github_pr_number function

- Rename function from get_default_pr_number to get_github_pr_number for clarity
- Simplify nested conditional logic for better readability
- Add qualifier to help text about GitHub Actions environment requirement
- Move function from upload.rs to vcs.rs for better organization

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: runningcode

src/commands/build/upload.rs

@@ -24,29 +24,10 @@ use crate::utils::fs::TempDir;
 use crate::utils::fs::TempFile;
 use crate::utils::progress::ProgressBar;
 use crate::utils::vcs::{
-    self, get_provider_from_remote, get_repo_from_remote, git_repo_head_ref, git_repo_remote_url,
+    self, get_github_pr_number, get_provider_from_remote, get_repo_from_remote, git_repo_head_ref,
+    git_repo_remote_url,
 };
 
-fn get_default_pr_number() -> Option<u32> {
-    std::env::var("GITHUB_REF").ok().and_then(|github_ref| {
-        if let Ok(event_name) = std::env::var("GITHUB_EVENT_NAME") {
-            if event_name == "pull_request" && github_ref.starts_with("refs/pull/") {
-                let pr_number_str = github_ref.strip_prefix("refs/pull/")?.split('/').next()?;
-                if let Ok(pr_number) = pr_number_str.parse::<u32>() {
-                    debug!("Auto-detected PR number from GitHub Actions: {}", pr_number);
-                    Some(pr_number)
-                } else {
-                    None
-                }
-            } else {
-                None
-            }
-        } else {
-            None
-        }
-    })
-}
-
 pub fn make_command(command: Command) -> Command {
     #[cfg(all(target_os = "macos", target_arch = "aarch64"))]
     const HELP_TEXT: &str =
@@ -105,7 +86,7 @@ pub fn make_command(command: Command) -> Command {
             Arg::new("pr_number")
                 .long("pr-number")
                 .value_parser(clap::value_parser!(u32))
-                .help("The pull request number to use for the upload. If not provided, the PR number will be automatically detected from GitHub Actions environment variables.")
+                .help("The pull request number to use for the upload. If not provided and running in a GitHub Actions environment, the PR number will be automatically detected from GitHub Actions environment variables.")
         )
         .arg(
             Arg::new("build_configuration")
@@ -196,7 +177,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
     let pr_number = matches
         .get_one::<u32>("pr_number")
         .copied()
-        .or_else(get_default_pr_number);
+        .or_else(get_github_pr_number);
 
     let build_configuration = matches.get_one("build_configuration").map(String::as_str);
     let release_notes = matches.get_one("release_notes").map(String::as_str);
@@ -622,20 +603,20 @@ mod tests {
     }
 
     #[test]
-    fn test_get_default_pr_number() {
+    fn test_get_github_pr_number() {
         std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
         std::env::set_var("GITHUB_REF", "refs/pull/123/merge");
 
-        let pr_number = get_default_pr_number();
+        let pr_number = get_github_pr_number();
         assert_eq!(pr_number, Some(123));
 
         std::env::set_var("GITHUB_EVENT_NAME", "push");
-        let pr_number = get_default_pr_number();
+        let pr_number = get_github_pr_number();
         assert_eq!(pr_number, None);
 
         std::env::set_var("GITHUB_EVENT_NAME", "pull_request");
         std::env::set_var("GITHUB_REF", "refs/heads/main");
-        let pr_number = get_default_pr_number();
+        let pr_number = get_github_pr_number();
         assert_eq!(pr_number, None);
 
         std::env::remove_var("GITHUB_EVENT_NAME");

src/utils/vcs.rs

@@ -249,6 +249,23 @@ pub fn git_repo_head_ref(repo: &git2::Repository) -> Result<String> {
     }
 }
 
+/// Attempts to get the PR number from GitHub Actions environment variables.
+/// Returns the PR number if running in a GitHub Actions pull request environment.
+pub fn get_github_pr_number() -> Option<u32> {
+    let github_ref = std::env::var("GITHUB_REF").ok()?;
+    let event_name = std::env::var("GITHUB_EVENT_NAME").ok()?;
+
+    if event_name != "pull_request" || !github_ref.starts_with("refs/pull/") {
+        return None;
+    }
+
+    let pr_number_str = github_ref.strip_prefix("refs/pull/")?.split('/').next()?;
+
+    let pr_number = pr_number_str.parse::<u32>().ok()?;
+    debug!("Auto-detected PR number from GitHub Actions: {}", pr_number);
+    Some(pr_number)
+}
+
 fn find_reference_url(repo: &str, repos: &[Repo]) -> Result<Option<String>> {
     let mut non_git = false;
     for configured_repo in repos {