Skip to content

Commit dcfaabf

Browse files
chore(proguard): Soft-deprecate the proguard upload --uuid flag (#3177)
Using `--uuid` can cause unexpected behavior, if the same ProGuard mapping is uploaded with different UUIDs. Therefore, we now recommend using `proguard uuid` to obtain the UUID of a mapping before upload, as this eliminates the need to manually set a UUID. Stacked on #3176 Closes #3172 Closes [CLI-296](https://linear.app/getsentry/issue/CLI-296/proguard-upload-manually-specified-uuid-not-respected)
1 parent ffc8502 commit dcfaabf

File tree

3 files changed

+8
-18
lines changed

3 files changed

+8
-18
lines changed

src/commands/proguard/upload.rs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,15 @@ pub fn make_command(command: Command) -> Command {
5959
.short('u')
6060
.value_name("UUID")
6161
.value_parser(Uuid::parse_str)
62+
.hide(true)
6263
.help(
63-
"Explicitly override the UUID of the mapping file with another one.{n}\
64-
This should be used with caution as it means that you can upload \
65-
multiple mapping files if you don't take care. This however can \
66-
be useful if you have a build process in which you need to know \
67-
the UUID of the proguard file before it was created. If you upload \
68-
a file with a forced UUID you can only upload a single proguard file.",
64+
"[DEPRECATED] Manually override the UUID for the uploaded mapping.\n\
65+
We no longer recommend using this option. \
66+
If you use this option, you must use it consistently, and you must \
67+
ensure the UUID is generated deterministically based on the ProGuard \
68+
mapping. \n\
69+
If you need to know the UUID before upload, we recommend using the \
70+
`proguard uuid` command.",
6971
),
7072
)
7173
}

tests/integration/_cases/proguard/proguard-upload-help.trycmd

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,6 @@ Options:
2626
flag is currently implemented only for selected subcommands.
2727
[aliases: --silent]
2828
--require-one Requires at least one file to upload or the command will error.
29-
-u, --uuid <UUID> Explicitly override the UUID of the mapping file with another one.
30-
This should be used with caution as it means that you can upload
31-
multiple mapping files if you don't take care. This however can be
32-
useful if you have a build process in which you need to know the
33-
UUID of the proguard file before it was created. If you upload a
34-
file with a forced UUID you can only upload a single proguard file.
3529
-h, --help Print help
3630

3731
```

tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,6 @@ Options:
2626
flag is currently implemented only for selected subcommands.
2727
[aliases: --silent]
2828
--require-one Requires at least one file to upload or the command will error.
29-
-u, --uuid <UUID> Explicitly override the UUID of the mapping file with another one.
30-
This should be used with caution as it means that you can upload
31-
multiple mapping files if you don't take care. This however can be
32-
useful if you have a build process in which you need to know the
33-
UUID of the proguard file before it was created. If you upload a
34-
file with a forced UUID you can only upload a single proguard file.
3529
-h, --help Print help
3630

3731
```

0 commit comments

Comments
 (0)