Skip to content

Commit e744afd

Browse files
runningcodeclaude
andauthored
fix(build): Ungate ProgressBarMode::Response from managed feature (#3247)
## Summary - `ProgressBarMode::Response` was gated behind `#[cfg(not(feature = "managed"))]` because its only consumer (`download_with_progress`) was also managed-gated - The new `download_installable_build` method (used by `build download`) references this variant without a managed gate, breaking the Docker build (`--features managed`) - The progress bar has nothing to do with managed mode — remove the feature gate from the variant and simplify the `response()` method #skip-changelog 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 5477440 commit e744afd

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

src/utils/progress.rs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ impl ProgressBar {
128128
#[derive(Clone)]
129129
pub enum ProgressBarMode {
130130
Disabled,
131-
#[cfg(not(feature = "managed"))]
132131
Response,
133132
Shared((Arc<ProgressBar>, u64, usize, Arc<RwLock<Vec<u64>>>)),
134133
}
@@ -141,12 +140,6 @@ impl ProgressBarMode {
141140

142141
/// Returns whether a progress bar should be displayed during download.
143142
pub fn response(&self) -> bool {
144-
#[cfg(not(feature = "managed"))]
145-
let rv = matches!(*self, ProgressBarMode::Response);
146-
147-
#[cfg(feature = "managed")]
148-
let rv = false;
149-
150-
rv
143+
matches!(*self, ProgressBarMode::Response)
151144
}
152145
}

0 commit comments

Comments
 (0)