address review comments

Author: shellmayr

src/api/mod.rs

@@ -1417,14 +1417,14 @@ impl<'a> AuthenticatedApi<'a> {
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum Dataset {
     /// Our logs dataset
-    OurLogs,
+    Logs,
 }
 
 impl Dataset {
     /// Returns the string representation of the dataset
     fn as_str(&self) -> &'static str {
         match self {
-            Dataset::OurLogs => "ourlogs",
+            Dataset::Logs => "logs",
         }
     }
 }
@@ -1447,13 +1447,12 @@ pub struct FetchEventsOptions<'a> {
     pub cursor: Option<&'a str>,
     /// Query string to filter events
     pub query: Option<&'a str>,
-    /// Number of events per page (default: 100)
+    /// Number of events per page
     pub per_page: Option<usize>,
-    /// Time period for stats (default: "1h")
+    /// Time period for stats
     pub stats_period: Option<&'a str>,
-    /// Sort order (default: "-timestamp")
-    pub sort: Option<&'a str>,
-}
+    /// Sort order
+    pub sort: Option<&'a str>,}
 
 impl<'a> FetchEventsOptions<'a> {
     /// Generate query parameters as a vector of strings

src/commands/logs/list.rs

@@ -88,7 +88,7 @@ fn execute_single_fetch(
     args: &ListLogsArgs,
 ) -> Result<()> {
     let options = FetchEventsOptions {
-        dataset: Dataset::OurLogs,
+        dataset: Dataset::Logs,
         fields,
         project_id: Some(project),
         cursor: None,

…ation/_cases/logs/logs-list-basic.trycmd …ases/logs/logs-list-no-logs-found.trycmdtests/integration/_cases/logs/logs-list-basic.trycmd renamed to tests/integration/_cases/logs/logs-list-no-logs-found.trycmd tests/integration/_cases/logs/logs-list-basic.trycmd renamed to tests/integration/_cases/logs/logs-list-no-logs-found.trycmd

@@ -6,7 +6,7 @@ fn command_logs_with_api_calls() {
         .mock_endpoint(
             MockEndpointBuilder::new(
                 "GET", 
-                "/api/0/organizations/wat-org/events/?dataset=ourlogs&field=sentry.item_id&field=trace&field=severity&field=timestamp&field=message&project=wat-project&per_page=100&statsPeriod=90d&sort=-timestamp"
+                "/api/0/organizations/wat-org/events/?dataset=logs&field=sentry.item_id&field=trace&field=severity&field=timestamp&field=message&project=wat-project&per_page=100&statsPeriod=90d&sort=-timestamp"
             )
             .with_response_file("logs/get-logs.json"),
         )
@@ -20,11 +20,11 @@ fn command_logs_basic() {
         .mock_endpoint(
             MockEndpointBuilder::new(
                 "GET", 
-                "/api/0/organizations/wat-org/events/?dataset=ourlogs&field=sentry.item_id&field=trace&field=severity&field=timestamp&field=message&project=12345&per_page=1&statsPeriod=90d&sort=-timestamp"
+                "/api/0/organizations/wat-org/events/?dataset=logs&field=sentry.item_id&field=trace&field=severity&field=timestamp&field=message&project=12345&per_page=1&statsPeriod=90d&sort=-timestamp"
             )
             .with_response_body(r#"{"data": []}"#),
         )
-        .register_trycmd_test("logs/logs-list-basic.trycmd")
+        .register_trycmd_test("logs/logs-list-no-logs-found.trycmd")
         .with_default_token();
 }