ci: Enable uninlined-format-args Clippy lint

Author: szokeasaurusrex

Cargo.toml

@@ -98,6 +98,7 @@ allow-attributes = "warn"
 str-to-string = "warn"
 string-to-string = "warn"
 unnecessary-wraps = "warn"
+uninlined-format-args = "warn"
 unused-trait-names = "warn"
 unwrap-used = "warn"
 

clippy.toml

@@ -1 +1,2 @@
+allow-mixed-uninlined-format-args = false
 allow-unwrap-in-tests = true

src/api/mod.rs

@@ -329,7 +329,7 @@ impl Api {
             _ => ARCH,
         };
 
-        let ref_name = format!("sentry-cli-{}-{}{}", capitalize_string(PLATFORM), arch, EXT);
+        let ref_name = format!("sentry-cli-{}-{arch}{EXT}", capitalize_string(PLATFORM));
         info!("Looking for file named: {}", ref_name);
 
         if resp.status() == 200 {
@@ -894,10 +894,9 @@ impl<'a> AuthenticatedApi<'a> {
         };
         self.put(
             &format!(
-                "/projects/{}/{}/issues/?{}",
+                "/projects/{}/{}/issues/?{qs}",
                 PathArg(org),
-                PathArg(project),
-                qs
+                PathArg(project)
             ),
             changes,
         )?
@@ -1252,7 +1251,7 @@ impl<'a> AuthenticatedApi<'a> {
         loop {
             requests_no += 1;
 
-            let resp = self.get(&format!("{}cursor={}", url, QueryArg(&cursor)))?;
+            let resp = self.get(&format!("{url}cursor={}", QueryArg(&cursor)))?;
 
             if resp.status() == 404 || (resp.status() == 400 && !cursor.is_empty()) {
                 if rv.is_empty() {
@@ -1933,7 +1932,7 @@ fn log_headers(is_response: bool, data: &[u8]) {
                 } else {
                     format!("{}***", &caps[3][..std::cmp::min(caps[3].len(), 8)])
                 };
-                format!("{}: {} {}", &caps[1], &caps[2], info)
+                format!("{}: {} {info}", &caps[1], &caps[2])
             });
             debug!("{} {}", if is_response { ">" } else { "<" }, replaced);
         }

src/commands/debug_files/check.rs

@@ -101,7 +101,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
     }
 
     if let Some(prob) = dif.get_problem() {
-        println!("  Usable: {} ({})", style("no").red(), prob);
+        println!("  Usable: {} ({prob})", style("no").red());
         Err(QuietExit(1).into())
     } else {
         println!("  Usable: {}", style("yes").green());

src/commands/debug_files/find.rs

@@ -186,7 +186,7 @@ fn find_ids(
             eprintln!();
             eprintln!("missing debug information files:");
             for id in &remaining {
-                eprintln!("  {} ({})", id, id_hint(id),);
+                eprintln!("  {id} ({})", id_hint(id),);
             }
         }
     }

src/commands/files/upload.rs

@@ -202,7 +202,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
             .iter()
             .map(|source| {
                 let local_path = source.path.strip_prefix(&source.base_path).unwrap();
-                let url = format!("{}/{}{}", url_prefix, path_as_url(local_path), url_suffix);
+                let url = format!("{url_prefix}/{}{url_suffix}", path_as_url(local_path));
 
                 (
                     url.clone(),

src/commands/monitors/run.rs

@@ -117,10 +117,9 @@ fn run_program(args: Vec<&String>, monitor_slug: &str) -> (bool, Option<i32>, Du
         Ok(status) => (status.success(), status.code()),
         Err(err) => {
             eprintln!(
-                "{} could not invoke program '{}': {}",
+                "{} could not invoke program '{}': {err}",
                 style("error").red(),
-                args[0],
-                err
+                args[0]
             );
             (false, None)
         }

src/commands/react_native/appcenter.rs

@@ -209,8 +209,8 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
         Some(dists) => {
             for dist in dists {
                 println!(
-                    "Uploading sourcemaps for release {} distribution {}",
-                    &release, dist
+                    "Uploading sourcemaps for release {} distribution {dist}",
+                    &release
                 );
 
                 processor.upload(&UploadContext {

src/commands/react_native/xcode.rs

@@ -361,7 +361,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                         // Successfully discovered and parsed Info.plist
                         let dist_string = plist.build().to_owned();
                         let release_string =
-                            format!("{}@{}+{}", plist.bundle_id(), plist.version(), dist_string);
+                            format!("{}@{}+{dist_string}", plist.bundle_id(), plist.version());
                         info!("Parse result from Info.plist: {:?}", &plist);
                         (Some(dist_string), Some(release_string))
                     }

src/commands/send_event.rs

@@ -213,7 +213,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
                 send_raw_event(event)?
             };
 
-            println!("Event from file {} dispatched: {}", path.display(), id);
+            println!("Event from file {} dispatched: {id}", path.display());
         }
 
         return Ok(());