Skip to content

Commit ec2a88b

Browse files
ci(node): Resolve browserslist to 4.25.4
Also, commit a `package-lock.json` (version 1, so we can use it with npm 6), so that we pin our dependencies in CI. Use `npm ci` to ensure we respect the lockfile. See browserslist/browserslist#905 (comment)
1 parent bcdc20b commit ec2a88b

File tree

4 files changed

+5302
-2
lines changed

4 files changed

+5302
-2
lines changed

.github/workflows/test_node.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
# We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet.
2323
# We have to use npm here because yarn fails on the non-existing existing optionalDependency version:
2424
# https://github.com/yarnpkg/berry/issues/2425#issuecomment-1627807326
25-
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install
25+
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm ci
2626

2727
- run: npm run check:types
2828

@@ -46,7 +46,7 @@ jobs:
4646
# We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet.
4747
# We have to use npm here because yarn fails on the non-existing existing optionalDependency version:
4848
# https://github.com/yarnpkg/berry/issues/2425#issuecomment-1627807326
49-
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install
49+
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm ci
5050

5151
# older node versions need an older nft
5252
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install @vercel/nft@0.22.1

.npmrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Compatibility with npm 6
2+
lockfile-version=1

0 commit comments

Comments
 (0)