ci: Enable unused-trait-names lint, fix violations (#2631)

https://rust-lang.github.io/rust-clippy/master/index.html#unused_trait_names

Author: szokeasaurusrex

Cargo.toml

@@ -103,6 +103,7 @@ allow-attributes = "warn"
 str-to-string = "warn"
 string-to-string = "warn"
 unnecessary-wraps = "warn"
+unused-trait-names = "warn"
 unwrap-used = "warn"
 
 [lints]

apple-catalog-parsing/src/asset_catalog.rs

@@ -1,5 +1,5 @@
 use std::ffi::CString;
-use std::os::unix::ffi::OsStrExt;
+use std::os::unix::ffi::OsStrExt as _;
 use std::path::Path;
 use thiserror::Error;
 

build.rs

@@ -1,7 +1,7 @@
 use std::env;
 use std::error::Error;
 use std::fs::File;
-use std::io::Write;
+use std::io::Write as _;
 use std::path::Path;
 
 fn main() -> Result<(), Box<dyn Error>> {

src/api/connection_manager.rs

@@ -22,7 +22,7 @@ impl r2d2::ManageConnection for CurlConnectionManager {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use r2d2::ManageConnection;
+    use r2d2::ManageConnection as _;
 
     #[test]
     fn test_connect() {

src/api/mod.rs

@@ -19,13 +19,13 @@ use std::collections::{HashMap, HashSet};
 use std::ffi::OsStr;
 use std::fmt;
 use std::fs::File;
-use std::io::{self, Read, Write};
+use std::io::{self, Read as _, Write};
 use std::path::Path;
 use std::rc::Rc;
 use std::sync::Arc;
 
-use anyhow::{Context, Result};
-use backoff::backoff::Backoff;
+use anyhow::{Context as _, Result};
+use backoff::backoff::Backoff as _;
 use brotli2::write::BrotliEncoder;
 #[cfg(target_os = "macos")]
 use chrono::Duration;
@@ -37,7 +37,7 @@ use lazy_static::lazy_static;
 use log::{debug, info, warn};
 use parking_lot::Mutex;
 use regex::{Captures, Regex};
-use secrecy::ExposeSecret;
+use secrecy::ExposeSecret as _;
 use sentry::protocol::{Exception, Values};
 use serde::de::DeserializeOwned;
 use serde::{Deserialize, Serialize};
@@ -52,7 +52,7 @@ use crate::constants::{ARCH, DEFAULT_URL, EXT, PLATFORM, RELEASE_REGISTRY_LATEST
 use crate::utils::file_upload::LegacyUploadContext;
 use crate::utils::http::{self, is_absolute_url};
 use crate::utils::progress::{ProgressBar, ProgressBarMode};
-use crate::utils::retry::{get_default_backoff, DurationAsMilliseconds};
+use crate::utils::retry::{get_default_backoff, DurationAsMilliseconds as _};
 use crate::utils::sourcemaps::get_sourcemap_reference_from_headers;
 use crate::utils::ui::{capitalize_string, make_byte_progress_bar};
 

src/commands/bash_hook.rs

@@ -4,7 +4,7 @@ use std::cmp::min;
 use std::collections::HashMap;
 use std::env;
 use std::fs;
-use std::io::{BufRead, BufReader};
+use std::io::{BufRead as _, BufReader};
 use std::path::Path;
 
 use anyhow::{format_err, Result};

src/commands/debug_files/bundle_jvm.rs

@@ -3,17 +3,17 @@
 use crate::api::Api;
 use crate::config::Config;
 use crate::constants::DEFAULT_MAX_WAIT;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 use crate::utils::file_search::ReleaseFileSearch;
 use crate::utils::file_upload::{FileUpload, SourceFile, UploadContext};
 use crate::utils::fs::path_as_url;
-use anyhow::{bail, Context, Result};
+use anyhow::{bail, Context as _, Result};
 use clap::{Arg, ArgMatches, Command};
 use sentry::types::DebugId;
 use std::collections::BTreeMap;
 use std::fs;
 use std::path::PathBuf;
-use std::str::FromStr;
+use std::str::FromStr as _;
 use std::sync::Arc;
 use symbolic::debuginfo::sourcebundle::SourceFileType;
 

src/commands/debug_files/find.rs

@@ -4,7 +4,7 @@ use std::ffi::OsStr;
 use std::fmt::Debug;
 use std::io;
 use std::path::PathBuf;
-use std::str::FromStr;
+use std::str::FromStr as _;
 
 use anyhow::Result;
 use clap::{builder::PossibleValuesParser, Arg, ArgAction, ArgMatches, Command};

src/commands/debug_files/upload.rs

@@ -1,17 +1,17 @@
 use std::collections::BTreeSet;
-use std::str::{self, FromStr};
+use std::str::{self, FromStr as _};
 use std::time::Duration;
 
 use anyhow::{bail, format_err, Result};
 use clap::{builder::PossibleValuesParser, Arg, ArgAction, ArgMatches, Command};
 use console::style;
-use itertools::Itertools;
+use itertools::Itertools as _;
 use symbolic::common::DebugId;
 use symbolic::debuginfo::FileFormat;
 
 use crate::config::Config;
 use crate::constants::DEFAULT_MAX_WAIT;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 use crate::utils::dif::{DifType, ObjectDifFeatures};
 use crate::utils::dif_upload::{DifFormat, DifUpload};
 use crate::utils::system::QuietExit;

src/commands/deploys/mod.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use clap::{ArgMatches, Command};
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod list;
 pub mod new;