Skip to content

Commit fc26480

Browse files
romtsnclaude
andcommitted
fix(proguard): Address PR feedback
- Use exhaustive match instead of wildcard in is_usable() and get_problem() to catch future DifFile variants at compile time - Add test verifying UUID generation succeeds for mappings without line info Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent af19d68 commit fc26480

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

src/utils/dif.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ impl<'a> DifFile<'a> {
380380
pub fn is_usable(&self) -> bool {
381381
match self {
382382
DifFile::Archive(_) => self.has_ids() && self.features().has_some(),
383-
_ => true,
383+
DifFile::Proguard(..) => true,
384384
}
385385
}
386386

@@ -391,7 +391,7 @@ impl<'a> DifFile<'a> {
391391
} else {
392392
"missing debug or unwind information"
393393
}),
394-
_ => None,
394+
DifFile::Archive(..) | DifFile::Proguard(..) => None,
395395
}
396396
}
397397

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
```
2+
$ sentry-cli proguard uuid tests/integration/_fixtures/proguard.txt
3+
? success
4+
5db7294d-87fc-5726-a5c0-4a90679657a5
5+
6+
```

0 commit comments

Comments
 (0)