Closed
Conversation
Member
|
FWIW I don't believe we want to ignore non-dsym files by default, as this would be potentially breaking. Perhaps having an option to ignore such files could be helpful, although even there I am unsure, as users could simply specify to the path to the specific debug file(s) they want to upload |
Member
|
@itaybre given lack of activity here, I am assuming we can probably close this PR. Please feel free to reopen if needed 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a PR ready to merge, but shows what we need to check for to ignore non dsym files