Merged
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/improve-readability
branch
from
0c204e4 to
501ff90
Compare
It is a bit weird to have this block defining two variables inside the definition of another variable. I think the following is a bit more readable. It also keeps the code DRY. Should be reviewed alongside #2618
szokeasaurusrex
force-pushed
the
szokeasaurusrex/improve-readability
branch
from
501ff90 to
25708db
Compare
loewenheim
approved these changes
Jul 16, 2025
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
I don't mind the variables in the block, but your version is still better even so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a bit weird to have this block defining two variables inside the definition of another variable.
I think the following is a bit more readable. It also keeps the code DRY.
Review alongside #2618, this is basically the changes I would have suggested on that PR