From 641f009f5ab49dd70e284feb97621071df04ec9a Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Wed, 16 Jul 2025 16:28:13 +0200 Subject: [PATCH 1/2] Revert "chore(ci): Use yarn for node tests instead of npm (#2612)" This reverts commit 355a8623e7cfde9fc939f7f4fea3ab5e5083a571. --- .github/workflows/test_node.yml | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test_node.yml b/.github/workflows/test_node.yml index 929b6b232b..2ae7891498 100644 --- a/.github/workflows/test_node.yml +++ b/.github/workflows/test_node.yml @@ -20,9 +20,9 @@ jobs: node-version-file: package.json # We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet. - - run: SENTRYCLI_SKIP_DOWNLOAD=1 yarn install --frozen-lockfile + - run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install - - run: yarn check:types + - run: npm run check:types test_node: strategy: @@ -42,13 +42,10 @@ jobs: node-version: ${{ matrix.node-version }} # We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet. - - run: SENTRYCLI_SKIP_DOWNLOAD=1 yarn install --frozen-lockfile - if: matrix.node-version != '10.x' && matrix.node-version != '12.x' + - run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install # older node versions need an older nft - - run: | - SENTRYCLI_SKIP_DOWNLOAD=1 yarn install --ignore-engines --frozen-lockfile - SENTRYCLI_SKIP_DOWNLOAD=1 yarn add @vercel/nft@0.22.1 --ignore-engines + - run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install @vercel/nft@0.22.1 if: matrix.node-version == '10.x' || matrix.node-version == '12.x' - - run: yarn test + - run: npm test From a6cd5aef31398c3b54e0232f1f9a1fe5f79cdd65 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Wed, 16 Jul 2025 16:31:46 +0200 Subject: [PATCH 2/2] add comment --- .github/workflows/test_node.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/test_node.yml b/.github/workflows/test_node.yml index 2ae7891498..ca3bb3c5f6 100644 --- a/.github/workflows/test_node.yml +++ b/.github/workflows/test_node.yml @@ -20,6 +20,8 @@ jobs: node-version-file: package.json # We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet. + # We have to use npm here because yarn fails on the non-existing existing optionalDependency version: + # https://github.com/yarnpkg/berry/issues/2425#issuecomment-1627807326 - run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install - run: npm run check:types @@ -42,6 +44,8 @@ jobs: node-version: ${{ matrix.node-version }} # We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet. + # We have to use npm here because yarn fails on the non-existing existing optionalDependency version: + # https://github.com/yarnpkg/berry/issues/2425#issuecomment-1627807326 - run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install # older node versions need an older nft