Skip to content

Revert "chore(ci): Use yarn for node tests instead of npm (#2612)" #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 2 commits into from
Jul 16, 2025
Merged

Revert "chore(ci): Use yarn for node tests instead of npm (#2612)" #2624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
641f009
Revert "chore(ci): Use yarn for node tests instead of npm (#2612)"
Lms24 Jul 16, 2025
a6cd5ae
add comment
Lms24 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/test_node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ jobs:
node-version-file: package.json

# We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet.
- run: SENTRYCLI_SKIP_DOWNLOAD=1 yarn install --frozen-lockfile
# We have to use npm here because yarn fails on the non-existing existing optionalDependency version:
# https://github.com/yarnpkg/berry/issues/2425#issuecomment-1627807326
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install

- run: yarn check:types
- run: npm run check:types

test_node:
strategy:
Expand All @@ -42,13 +44,12 @@ jobs:
node-version: ${{ matrix.node-version }}

# We need to skip the fallback download because downloading will fail on release branches because the new version isn't available yet.
- run: SENTRYCLI_SKIP_DOWNLOAD=1 yarn install --frozen-lockfile
if: matrix.node-version != '10.x' && matrix.node-version != '12.x'
# We have to use npm here because yarn fails on the non-existing existing optionalDependency version:
# https://github.com/yarnpkg/berry/issues/2425#issuecomment-1627807326
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install

# older node versions need an older nft
- run: |
SENTRYCLI_SKIP_DOWNLOAD=1 yarn install --ignore-engines --frozen-lockfile
SENTRYCLI_SKIP_DOWNLOAD=1 yarn add @vercel/nft@0.22.1 --ignore-engines
- run: SENTRYCLI_SKIP_DOWNLOAD=1 npm install @vercel/nft@0.22.1
if: matrix.node-version == '10.x' || matrix.node-version == '12.x'

- run: yarn test
- run: npm test