ci: Enable unused-trait-names lint, fix violations

Cargo.toml

@@ -103,6 +103,7 @@ allow-attributes = "warn"
 str-to-string = "warn"
 string-to-string = "warn"
 unnecessary-wraps = "warn"
+unused-trait-names = "warn"
 unwrap-used = "warn"
 
 [lints]

apple-catalog-parsing/src/asset_catalog.rs

@@ -1,5 +1,5 @@
 use std::ffi::CString;
-use std::os::unix::ffi::OsStrExt;
+use std::os::unix::ffi::OsStrExt as _;
 use std::path::Path;
 use thiserror::Error;
 

build.rs

@@ -1,7 +1,7 @@
 use std::env;
 use std::error::Error;
 use std::fs::File;
-use std::io::Write;
+use std::io::Write as _;
 use std::path::Path;
 
 fn main() -> Result<(), Box<dyn Error>> {

src/api/connection_manager.rs

@@ -22,7 +22,7 @@ impl r2d2::ManageConnection for CurlConnectionManager {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use r2d2::ManageConnection;
+    use r2d2::ManageConnection as _;
 
     #[test]
     fn test_connect() {

src/api/mod.rs

@@ -19,13 +19,13 @@ use std::collections::{HashMap, HashSet};
 use std::ffi::OsStr;
 use std::fmt;
 use std::fs::File;
-use std::io::{self, Read, Write};
+use std::io::{self, Read as _, Write};
 use std::path::Path;
 use std::rc::Rc;
 use std::sync::Arc;
 
-use anyhow::{Context, Result};
-use backoff::backoff::Backoff;
+use anyhow::{Context as _, Result};
+use backoff::backoff::Backoff as _;
 use brotli2::write::BrotliEncoder;
 #[cfg(target_os = "macos")]
 use chrono::Duration;
@@ -37,7 +37,7 @@ use lazy_static::lazy_static;
 use log::{debug, info, warn};
 use parking_lot::Mutex;
 use regex::{Captures, Regex};
-use secrecy::ExposeSecret;
+use secrecy::ExposeSecret as _;
 use sentry::protocol::{Exception, Values};
 use serde::de::DeserializeOwned;
 use serde::{Deserialize, Serialize};
@@ -52,7 +52,7 @@ use crate::constants::{ARCH, DEFAULT_URL, EXT, PLATFORM, RELEASE_REGISTRY_LATEST
 use crate::utils::file_upload::LegacyUploadContext;
 use crate::utils::http::{self, is_absolute_url};
 use crate::utils::progress::{ProgressBar, ProgressBarMode};
-use crate::utils::retry::{get_default_backoff, DurationAsMilliseconds};
+use crate::utils::retry::{get_default_backoff, DurationAsMilliseconds as _};
 use crate::utils::sourcemaps::get_sourcemap_reference_from_headers;
 use crate::utils::ui::{capitalize_string, make_byte_progress_bar};
 

src/commands/bash_hook.rs

@@ -4,7 +4,7 @@ use std::cmp::min;
 use std::collections::HashMap;
 use std::env;
 use std::fs;
-use std::io::{BufRead, BufReader};
+use std::io::{BufRead as _, BufReader};
 use std::path::Path;
 
 use anyhow::{format_err, Result};

src/commands/debug_files/bundle_jvm.rs

@@ -3,17 +3,17 @@
 use crate::api::Api;
 use crate::config::Config;
 use crate::constants::DEFAULT_MAX_WAIT;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 use crate::utils::file_search::ReleaseFileSearch;
 use crate::utils::file_upload::{FileUpload, SourceFile, UploadContext};
 use crate::utils::fs::path_as_url;
-use anyhow::{bail, Context, Result};
+use anyhow::{bail, Context as _, Result};
 use clap::{Arg, ArgMatches, Command};
 use sentry::types::DebugId;
 use std::collections::BTreeMap;
 use std::fs;
 use std::path::PathBuf;
-use std::str::FromStr;
+use std::str::FromStr as _;
 use std::sync::Arc;
 use symbolic::debuginfo::sourcebundle::SourceFileType;
 

src/commands/debug_files/find.rs

@@ -4,7 +4,7 @@ use std::ffi::OsStr;
 use std::fmt::Debug;
 use std::io;
 use std::path::PathBuf;
-use std::str::FromStr;
+use std::str::FromStr as _;
 
 use anyhow::Result;
 use clap::{builder::PossibleValuesParser, Arg, ArgAction, ArgMatches, Command};

src/commands/debug_files/upload.rs

@@ -1,17 +1,17 @@
 use std::collections::BTreeSet;
-use std::str::{self, FromStr};
+use std::str::{self, FromStr as _};
 use std::time::Duration;
 
 use anyhow::{bail, format_err, Result};
 use clap::{builder::PossibleValuesParser, Arg, ArgAction, ArgMatches, Command};
 use console::style;
-use itertools::Itertools;
+use itertools::Itertools as _;
 use symbolic::common::DebugId;
 use symbolic::debuginfo::FileFormat;
 
 use crate::config::Config;
 use crate::constants::DEFAULT_MAX_WAIT;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 use crate::utils::dif::{DifType, ObjectDifFeatures};
 use crate::utils::dif_upload::{DifFormat, DifUpload};
 use crate::utils::system::QuietExit;

src/commands/deploys/mod.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use clap::{ArgMatches, Command};
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod list;
 pub mod new;

src/commands/events/mod.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use clap::{ArgMatches, Command};
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod list;
 

src/commands/files/mod.rs

@@ -2,7 +2,7 @@ use anyhow::Result;
 use clap::{ArgMatches, Command};
 use console::style;
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod delete;
 pub mod list;

src/commands/files/upload.rs

@@ -3,7 +3,7 @@
 use std::collections::BTreeMap;
 use std::ffi::OsStr;
 use std::fs;
-use std::io::Read;
+use std::io::Read as _;
 use std::path::Path;
 use std::sync::Arc;
 use std::time::Duration;

src/commands/issues/mod.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use clap::{Arg, ArgAction, ArgMatches, Command};
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod list;
 pub mod mute;

src/commands/mobile_app/mod.rs

@@ -3,7 +3,7 @@
 use anyhow::Result;
 use clap::{ArgMatches, Command};
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod upload;
 

src/commands/mobile_app/upload.rs

@@ -1,15 +1,15 @@
 use std::borrow::Cow;
 #[cfg(not(windows))]
 use std::fs;
-use std::io::Write;
+use std::io::Write as _;
 #[cfg(not(windows))]
-use std::os::unix::fs::PermissionsExt;
+use std::os::unix::fs::PermissionsExt as _;
 use std::path::Path;
 
 use anyhow::{anyhow, bail, Context as _, Result};
 use clap::{Arg, ArgAction, ArgMatches, Command};
 use indicatif::ProgressStyle;
-use itertools::Itertools;
+use itertools::Itertools as _;
 use log::{debug, info, warn};
 use sha1_smol::Digest;
 use symbolic::common::ByteView;
@@ -18,7 +18,7 @@ use zip::{DateTime, ZipWriter};
 
 use crate::api::{Api, AuthenticatedApi, ChunkUploadCapability};
 use crate::config::Config;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 use crate::utils::chunks::{upload_chunks, Chunk, ASSEMBLE_POLL_INTERVAL};
 use crate::utils::fs::get_sha1_checksums;
 use crate::utils::fs::TempFile;

src/commands/monitors/list.rs

@@ -3,7 +3,7 @@ use clap::{ArgMatches, Command};
 
 use crate::api::Api;
 use crate::config::Config;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 use crate::utils::formatting::Table;
 
 pub fn make_command(command: Command) -> Command {

src/commands/projects/mod.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use clap::{ArgMatches, Command};
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod list;
 

src/commands/react_native/appcenter.rs

@@ -14,7 +14,7 @@ use crate::api::Api;
 use crate::config::Config;
 use crate::constants::DEFAULT_MAX_WAIT;
 use crate::utils::appcenter::{get_appcenter_package, get_react_native_appcenter_release};
-use crate::utils::args::{validate_distribution, ArgExt};
+use crate::utils::args::{validate_distribution, ArgExt as _};
 use crate::utils::file_search::ReleaseFileSearch;
 use crate::utils::file_upload::UploadContext;
 use crate::utils::sourcemaps::SourceMapProcessor;

src/commands/react_native/gradle.rs

@@ -12,7 +12,7 @@ use sourcemap::ram_bundle::RamBundle;
 use crate::api::Api;
 use crate::config::Config;
 use crate::constants::DEFAULT_MAX_WAIT;
-use crate::utils::args::{validate_distribution, ArgExt};
+use crate::utils::args::{validate_distribution, ArgExt as _};
 use crate::utils::file_search::ReleaseFileSearch;
 use crate::utils::file_upload::{SourceFile, UploadContext};
 use crate::utils::sourcemaps::SourceMapProcessor;

src/commands/react_native/xcode.rs

@@ -18,7 +18,7 @@ use serde_json::Value;
 use crate::api::Api;
 use crate::config::Config;
 use crate::constants::DEFAULT_MAX_WAIT;
-use crate::utils::args::{validate_distribution, ArgExt};
+use crate::utils::args::{validate_distribution, ArgExt as _};
 use crate::utils::file_search::ReleaseFileSearch;
 use crate::utils::file_upload::UploadContext;
 use crate::utils::fs::TempFile;

src/commands/releases/archive.rs

@@ -3,7 +3,7 @@ use clap::{ArgMatches, Command};
 
 use crate::api::{Api, ReleaseStatus, UpdatedRelease};
 use crate::config::Config;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub fn make_command(command: Command) -> Command {
     command

src/commands/releases/delete.rs

@@ -3,7 +3,7 @@ use clap::{ArgMatches, Command};
 
 use crate::api::Api;
 use crate::config::Config;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub fn make_command(command: Command) -> Command {
     command

src/commands/releases/finalize.rs

@@ -4,7 +4,7 @@ use clap::{Arg, ArgMatches, Command};
 
 use crate::api::{Api, UpdatedRelease};
 use crate::config::Config;
-use crate::utils::args::{get_timestamp, ArgExt};
+use crate::utils::args::{get_timestamp, ArgExt as _};
 
 pub fn make_command(command: Command) -> Command {
     command

src/commands/releases/info.rs

@@ -3,7 +3,7 @@ use clap::{Arg, ArgAction, ArgMatches, Command};
 
 use crate::api::Api;
 use crate::config::Config;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 use crate::utils::formatting::Table;
 use crate::utils::logging::is_quiet_mode;
 use crate::utils::system::QuietExit;

src/commands/releases/mod.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use clap::{ArgMatches, Command};
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod archive;
 pub mod delete;

src/commands/releases/new.rs

@@ -4,7 +4,7 @@ use clap::{Arg, ArgAction, ArgMatches, Command};
 
 use crate::api::{Api, NewRelease};
 use crate::config::Config;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub fn make_command(command: Command) -> Command {
     command

src/commands/releases/restore.rs

@@ -3,7 +3,7 @@ use clap::{ArgMatches, Command};
 
 use crate::api::{Api, ReleaseStatus, UpdatedRelease};
 use crate::config::Config;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub fn make_command(command: Command) -> Command {
     command

src/commands/releases/set_commits.rs

@@ -7,7 +7,7 @@ use regex::Regex;
 
 use crate::api::{Api, NewRelease, NoneReleaseInfo, OptionalReleaseInfo, UpdatedRelease};
 use crate::config::Config;
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 use crate::utils::formatting::Table;
 use crate::utils::vcs::{
     find_heads, generate_patch_set, get_commits_from_git, get_repo_from_remote, CommitSpec,

src/commands/repos/mod.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use clap::{ArgMatches, Command};
 
-use crate::utils::args::ArgExt;
+use crate::utils::args::ArgExt as _;
 
 pub mod list;
 

src/commands/send_event.rs

@@ -7,7 +7,7 @@ use anyhow::{anyhow, format_err, Result};
 use chrono::{DateTime, Utc};
 use clap::{Arg, ArgAction, ArgMatches, Command};
 use glob::{glob_with, MatchOptions};
-use itertools::Itertools;
+use itertools::Itertools as _;
 use log::warn;
 use sentry::protocol::{Event, Level, LogEntry, User};
 use sentry::types::Uuid;
@@ -190,7 +190,7 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
             let raw_event = std::fs::read(&path)?;
 
             let id = if raw {
-                use std::io::Write;
+                use std::io::Write as _;
 
                 // Its a bit unfortunate that we still need to parse the whole JSON,
                 // but envelopes need an `event_id`, which we also want to report.

src/commands/send_metric/distribution.rs

@@ -1,5 +1,5 @@
 use super::common_args::FloatValueMetricArgs;
-use crate::{api::envelopes_api::EnvelopesApi, utils::metrics::DefaultTags};
+use crate::{api::envelopes_api::EnvelopesApi, utils::metrics::DefaultTags as _};
 use anyhow::Result;
 use sentry::metrics::Metric;
 

src/commands/send_metric/gauge.rs

@@ -1,5 +1,5 @@
 use super::common_args::FloatValueMetricArgs;
-use crate::{api::envelopes_api::EnvelopesApi, utils::metrics::DefaultTags};
+use crate::{api::envelopes_api::EnvelopesApi, utils::metrics::DefaultTags as _};
 use anyhow::Result;
 use sentry::metrics::Metric;
 

src/commands/send_metric/increment.rs

@@ -1,5 +1,5 @@
 use super::common_args::CommonMetricArgs;
-use crate::{api::envelopes_api::EnvelopesApi, utils::metrics::DefaultTags};
+use crate::{api::envelopes_api::EnvelopesApi, utils::metrics::DefaultTags as _};
 use anyhow::Result;
 use clap::{command, Args};
 use sentry::metrics::Metric;

src/commands/send_metric/mod.rs

@@ -11,7 +11,7 @@ use self::set::SetMetricArgs;
 use super::derive_parser::{SentryCLI, SentryCLICommand};
 use anyhow::Result;
 use clap::{command, Args, Subcommand};
-use clap::{ArgMatches, Command, Parser};
+use clap::{ArgMatches, Command, Parser as _};
 
 const DEPRECATION_MESSAGE: &str = "DEPRECATION NOTICE: \
     The send-metric commands are deprecated and will be \

src/commands/send_metric/set.rs

@@ -1,5 +1,5 @@
 use super::common_args::CommonMetricArgs;
-use crate::{api::envelopes_api::EnvelopesApi, utils::metrics::DefaultTags};
+use crate::{api::envelopes_api::EnvelopesApi, utils::metrics::DefaultTags as _};
 use anyhow::Result;
 use clap::{command, Args};
 use sentry::metrics::Metric;

src/commands/sourcemaps/explain.rs

@@ -1,6 +1,6 @@
 #![expect(clippy::unwrap_used, reason = "deprecated command")]
 
-use std::io::Read;
+use std::io::Read as _;
 use std::path::Path;
 
 use anyhow::{bail, format_err, Result};