meta: Enforce Sentry commit message conventions#2652
Closed
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/add-precommitfrom
Closed
meta: Enforce Sentry commit message conventions#2652szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/add-precommitfrom
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/add-precommitfrom
Conversation
Co-authored-by: daniel.szoke <daniel.szoke@sentry.io>
szokeasaurusrex
force-pushed
the
cursor/implement-phase-one-of-plan-3499
branch
from
215b874 to
b46a6ab
Compare
szokeasaurusrex
changed the title
Member
Author
|
After discussion with @dingsdax, perhaps enforcing the commit message convention on each commit is overkill, as we typically squash and merge anyways. We plan to introduce a new PR template, which would instruct contributors to follow the commit naming convention in the PR title, let's see if that solves the problem before reconsidering automated enforcement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: daniel.szoke daniel.szoke@sentry.io