test: Make tests pass with custom --target#2657
Merged
szokeasaurusrex merged 1 commit intomasterfrom Jul 28, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
szokeasaurusrex
force-pushed
the
07-28-test_make_tests_pass_with_custom_--target_
branch
2 times, most recently
from
cc37192 to
52e1dd8
Compare
loewenheim
approved these changes
Jul 28, 2025
Currently, some tests fail because they assert `target/debug/sentry-cli` as the path to the binary. This fails when running `cargo test` with a custom `--target`. Instead, let's stop asserting the path to the binary.
szokeasaurusrex
force-pushed
the
07-28-test_make_tests_pass_with_custom_--target_
branch
from
52e1dd8 to
a39314e
Compare
szokeasaurusrex
requested review from
a team and
loewenheim
and removed request for
a team and
loewenheim
lcian
approved these changes
Jul 28, 2025
szokeasaurusrex
deleted the
07-28-test_make_tests_pass_with_custom_--target_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some tests fail because they assert
target/debug/sentry-clias the path to the binary. This fails when runningcargo testwith a custom--target.Instead, let's stop asserting the path to the binary.